Skip to content

Commit 7da68d3

Browse files
authored
fixup! chore(origins): include xoauth origins when requesting permissions (#12315) (#12316)
1 parent 27a5ae1 commit 7da68d3

File tree

2 files changed

+14
-15
lines changed

2 files changed

+14
-15
lines changed

packages/mask/dashboard/pages/SetupPersona/Onboarding/index.tsx

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
1-
import { memo, useCallback, useEffect, useMemo } from 'react'
2-
import { Box, Typography, useTheme } from '@mui/material'
3-
import { SetupFrameController } from '../../../components/SetupFrame/index.js'
4-
import { PrimaryButton } from '../../../components/PrimaryButton/index.js'
5-
import { makeStyles, useCustomSnackbar } from '@masknet/theme'
61
import { Icons } from '@masknet/icons'
7-
import { Trend } from '../../../assets/index.js'
82
import { CrossIsolationMessages, EnhanceableSite, PopupRoutes, userGuideStatus } from '@masknet/shared-base'
3+
import { makeStyles, useCustomSnackbar } from '@masknet/theme'
4+
import { Box, Typography } from '@mui/material'
5+
import { memo, useCallback, useEffect, useMemo } from 'react'
6+
import { Trend } from '../../../assets/index.js'
7+
import { PrimaryButton } from '../../../components/PrimaryButton/index.js'
8+
import { SetupFrameController } from '../../../components/SetupFrame/index.js'
99

1010
import Services from '#services'
11+
import { plural } from '@lingui/core/macro'
12+
import { Trans, useLingui } from '@lingui/react/macro'
1113
import { delay } from '@masknet/kit'
12-
import { OnboardingWriter } from '../../../components/OnboardingWriter/index.js'
13-
import { useSearchParams } from 'react-router-dom'
1414
import { isZero } from '@masknet/web3-shared-base'
15+
import { useSearchParams } from 'react-router-dom'
1516
import { useAsyncRetry } from 'react-use'
16-
import { TwitterAdaptor } from '../../../../shared/site-adaptors/implementations/twitter.com.js'
1717
import { requestPermissionFromExtensionPage } from '../../../../shared-ui/index.js'
18-
import { Trans, useLingui } from '@lingui/react/macro'
19-
import { plural } from '@lingui/core/macro'
18+
import { TwitterAdaptor } from '../../../../shared/site-adaptors/implementations/twitter.com.js'
19+
import { OnboardingWriter } from '../../../components/OnboardingWriter/index.js'
2020

2121
const useStyles = makeStyles()((theme) => ({
2222
card: {
@@ -81,7 +81,6 @@ export const Component = memo(function Onboarding() {
8181

8282
const [params] = useSearchParams()
8383
const { showSnackbar } = useCustomSnackbar()
84-
const theme = useTheme()
8584
const isCreate = params.get('isCreate')
8685
const count = params.get('count')
8786
const { value: hasPaymentPassword, loading, retry } = useAsyncRetry(Services.Wallet.hasPassword, [])

packages/mask/dashboard/pages/SetupPersona/Welcome/index.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import { SecondaryButton } from '../../../components/SecondaryButton/index.js'
1414
import { SetupFrameController } from '../../../components/SetupFrame/index.js'
1515
import { TermsAgreedContext } from '../../../hooks/useTermsAgreed.js'
1616
import { Article } from './Article.js'
17+
import { XOAuthRequestOrigins } from '../../../../shared/definitions/extension.js'
1718

1819
const useStyles = makeStyles()((theme) => ({
1920
title: {
@@ -65,9 +66,8 @@ export const Component = memo(function Welcome() {
6566
setAgreed(true)
6667

6768
try {
68-
const granted = await requestPermissionFromExtensionPage(
69-
[...definedSiteAdaptors.values()].flatMap((x) => x.declarativePermissions.origins),
70-
)
69+
const siteOrigins = [...definedSiteAdaptors.values()].flatMap((x) => x.declarativePermissions.origins)
70+
const granted = await requestPermissionFromExtensionPage([...siteOrigins, ...XOAuthRequestOrigins])
7171
if (!granted) return
7272
if (!userGuideStatus[EnhanceableSite.Twitter].value) userGuideStatus[EnhanceableSite.Twitter].value = '1'
7373
} catch (err) {

0 commit comments

Comments
 (0)