refactor: enable some eslint rules (#12231)

Author: Jack-Works

eslint.config.js

@@ -43,9 +43,8 @@ const avoidMistakeRules = {
     '@tanstack/query/no-unstable-deps': 'error', // avoid unstable results from the hook being deps
     '@tanstack/query/no-void-query-fn': 'error', // query function should always return something
     '@lingui/no-single-tag-to-translate': 'error',
-    // '@lingui/no-single-variables-to-translate': 'error', // we're mixing two i18n frameworks, a lot of false positive reports
-    // https://github.com/lingui/eslint-plugin/issues/46
-    // '@lingui/no-unlocalized-strings': 'error',
+    // https://github.com/lingui/eslint-plugin/issues/104
+    // '@lingui/no-single-variables-to-translate': 'error',
     '@lingui/no-trans-inside-trans': 'error',
     '@lingui/t-call-in-function': 'error',
 
@@ -108,7 +107,7 @@ const avoidMistakeRules = {
     /// Unicode support
     'no-misleading-character-class': 'error', // RegEx
     'require-unicode-regexp': 'error', // RegEx modern RegEx with Unicode support
-    // 'unicorn/prefer-code-point': 'error',
+    'unicorn/prefer-code-point': 'error',
     // '@masknet/no-builtin-base64': 'warn', // Note: it fixes to Node's Buffer
     /// type safety
     // '@typescript-eslint/method-signature-style': 'warn', // method signature is bivariant
@@ -249,8 +248,7 @@ const codeStyleRules = {
     'react/no-class-component': 'error',
     'react/no-context-provider': 'error',
     'react/no-forward-ref': 'error',
-    // Let's wait for https://github.com/typescript-eslint/typescript-eslint/issues/6572
-    // '@typescript-eslint/no-namespace': 'error', // namespace T {}
+    // '@typescript-eslint/no-namespace': 'error', // namespace T {}, they won't support type only namespace
     '@typescript-eslint/prefer-namespace-keyword': 'error', // but if you really need to, don't use `module T {}`
 
     // Useless code
@@ -431,12 +429,12 @@ const codeStyleRules = {
 
     // Bad practice
     'no-ex-assign': 'warn', // reassign err in catch
-    // 'no-multi-assign': 'warn', // a = b = c
+    'no-multi-assign': 'warn', // a = b = c
     // 'no-param-reassign': 'warn',
-    // 'no-return-assign': 'warn', // return x = expr
-    // 'unicorn/no-object-as-default-parameter': 'warn',
-    // '@typescript-eslint/default-param-last': 'warn', // (a, b = 1, c)
-    // '@typescript-eslint/no-dynamic-delete': 'error', // this usually means you should use Map/Set
+    'no-return-assign': 'warn', // return x = expr
+    'unicorn/no-object-as-default-parameter': 'warn',
+    '@typescript-eslint/default-param-last': 'warn', // (a, b = 1, c)
+    '@typescript-eslint/no-dynamic-delete': 'error', // this usually means you should use Map/Set
     /// Async functions / Promise bad practice
     'no-async-promise-executor': 'error', // new Promise(async (resolve) => )
     'no-promise-executor-return': 'error', // new Promise(() => result)
@@ -577,6 +575,7 @@ const plugins = {
     'react-hooks': ReactHooksPlugin,
     'react-compiler': ReactCompilerPlugin,
     '@tanstack/query': ReactQueryPlugin,
+    // @ts-ignore
     '@lingui': fixupPluginRules(LinguiPlugin),
 }
 export default tseslint.config(

packages/backup-format/tests/encryption.ts

@@ -16,13 +16,13 @@ const testData = new Uint8Array([
 ])
 
 test('Old data can be still decrypted', async () => {
-    const password = Uint8Array.from('password'.split('').map((x) => x.charCodeAt(0)))
+    const password = Uint8Array.from('password'.split('').map((x) => x.codePointAt(0)))
     const decrypted = await decryptBackup(password, testData)
     expect(new Uint8Array(decrypted)).toEqual(rawData)
 })
 
 test('decrypt(password, encrypt(password, data)) === data', async () => {
-    const password = Uint8Array.from('password'.split('').map((x) => x.charCodeAt(0)))
+    const password = Uint8Array.from('password'.split('').map((x) => x.codePointAt(0)))
     const data = new Uint8Array([4, 5, 6])
 
     const result = await encryptBackup(password, data)

packages/base/src/Identifier/identifier.ts

@@ -169,7 +169,8 @@ export class PostIVIdentifier extends Identifier {
             console.warn('[@masknet/shared-base] For compatibility, x.com is converted to twitter.com')
         }
 
-        const networkCache = (PostIVIdentifier.#cache[network] ??= {})
+        PostIVIdentifier.#cache[network] ??= {}
+        const networkCache = PostIVIdentifier.#cache[network]
         // return the cache to keep the object identity
         // eslint-disable-next-line no-constructor-return
         if (networkCache[postIV]) return networkCache[postIV]
@@ -286,7 +287,8 @@ export class ProfileIdentifier extends Identifier {
         }
         if (!userID) throw new TypeError('[@masknet/base] userID cannot be empty.')
 
-        const networkCache = (ProfileIdentifier.#cache[network] ??= {})
+        ProfileIdentifier.#cache[network] ??= {}
+        const networkCache = ProfileIdentifier.#cache[network]
         // return the cache to keep the object identity
         // eslint-disable-next-line no-constructor-return
         if (networkCache[userID]) return networkCache[userID]

packages/gun-utils/src/instance.ts

@@ -13,17 +13,19 @@ function createGun() {
     class WebSocket extends globalThis.WebSocket {
         constructor(url: string | URL) {
             super(url)
-            const abort = (this.abort = () => {
+            this.abort = () => {
                 gun?.off()
                 gun = undefined
                 this.close()
                 for (const each of OnCloseEvent) each()
                 console.log('[Network/gun] WebSocket of the Gun instance is killed due to inactive.')
-            })
-            const keepAlive = (this.keepAlive = () => {
+            }
+            const abort = this.abort
+            this.keepAlive = () => {
                 if (this.timer) clearTimeout(this.timer)
                 this.timer = setTimeout(abort, 3 * 60 * 1000)
-            })
+            }
+            const keepAlive = this.keepAlive
             this.addEventListener(
                 'message',
                 (e) => {

packages/injected-script/main/Patches/Event.ts

@@ -149,7 +149,8 @@ export class __Event extends $unsafe.NewObject implements Event {
         event.#stopPropagation = false
         event.#stopImmediatePropagation = false
         if (clearTargets) {
-            event.#target = event.#relatedTarget = null
+            event.#relatedTarget = null
+            event.#target = null
             event.#touchTargetList = $safe.Array_of()
         }
         if (activationTarget !== null) {

packages/injected-script/main/intrinsic_blessed.ts

@@ -39,11 +39,12 @@ const ArrayIteratorPrototype: IterableIterator<any> = create(
     const entries = takeThisF(MapPrototype.entries)<T>
     const keys = takeThisF(MapPrototype.keys)<T>
     const values = takeThisF(MapPrototype.values)<T>
-    MapPrototype.entries = MapPrototype[Symbol.iterator] = function (this: T) {
+    MapPrototype[Symbol.iterator] = function (this: T) {
         const iter = entries(this)
         setPrototypeOf(iter, MapIteratorPrototype)
         return iter
     }
+    MapPrototype.entries = MapPrototype[Symbol.iterator]
     MapPrototype.keys = function (this: T) {
         const iter = keys(this)
         setPrototypeOf(iter, MapIteratorPrototype)
@@ -66,14 +67,13 @@ const ArrayIteratorPrototype: IterableIterator<any> = create(
         setPrototypeOf(iter, SetIteratorPrototype)
         return iter
     }
-    SetPrototype.values =
-        SetPrototype.keys =
-        SetPrototype[Symbol.iterator] =
-            function (this: T) {
-                const iter = values(this)
-                setPrototypeOf(iter, SetIteratorPrototype)
-                return iter
-            }
+    SetPrototype[Symbol.iterator] = function (this: T) {
+        const iter = values(this)
+        setPrototypeOf(iter, SetIteratorPrototype)
+        return iter
+    }
+    SetPrototype.keys = SetPrototype[Symbol.iterator]
+    SetPrototype.values = SetPrototype[Symbol.iterator]
 }
 
 // Array
@@ -92,11 +92,12 @@ const ArrayIteratorPrototype: IterableIterator<any> = create(
         setPrototypeOf(iter, ArrayIteratorPrototype)
         return iter
     }
-    ArrayPrototype.values = ArrayPrototype[Symbol.iterator] = function (this: T) {
+    ArrayPrototype[Symbol.iterator] = function (this: T) {
         const iter = values(this)
         setPrototypeOf(iter, ArrayIteratorPrototype)
         return iter
     }
+    ArrayPrototype.values = ArrayPrototype[Symbol.iterator]
 }
 
 export function Map<K, V>(): Map<K, V> {

packages/mask/background/database/persona/web.ts

@@ -304,6 +304,7 @@ export async function updatePersonaDB(
         const keys = Object.keys(nextRecord) as Array<keyof typeof nextRecord>
         for (const key of keys) {
             if (nextRecord[key] === undefined) {
+                // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
                 delete nextRecord[key]
             }
         }

packages/mask/background/database/utils/openDB.ts

@@ -88,7 +88,8 @@ export function createDBAccessWithAsyncUpgrade<DBSchema, AsyncUpgradePreparedDat
 
         // Share a Promise to prevent async upgrade for multiple times
         if (pendingOpen) return pendingOpen
-        const promise = (pendingOpen = open())
+        pendingOpen = open()
+        const promise = pendingOpen
         promise.catch(() => (pendingOpen = undefined))
         return promise
     }

packages/mask/background/network/queryPostKey.ts

@@ -205,6 +205,7 @@ async function GUN_SEA_work(data: Uint8Array | string, salt: Uint8Array | string
     const key = await crypto.subtle.importKey('raw', data, { name: 'PBKDF2' }, false, ['deriveBits'])
     const params: Pbkdf2Params = { name: 'PBKDF2', iterations: 100000, salt, hash: { name: 'SHA-256' } }
     const derived = await crypto.subtle.deriveBits(params, key, 512)
+    // eslint-disable-next-line unicorn/prefer-code-point
     return btoa(String.fromCharCode(...new Uint8Array(derived)))
 }
 

packages/mask/background/tasks/Cancellable/StartSandboxedPluginHost.ts

@@ -20,7 +20,8 @@ let hot:
     | undefined
 if (process.env.NODE_ENV === 'development') {
     const sym = Symbol.for('sandboxed plugin bridge hot map')
-    hot = (globalThis as any)[sym] ??= new Map()
+    ;(globalThis as any)[sym] ??= new Map()
+    hot = (globalThis as any)[sym]
 }
 
 if (Flags.sandboxedPluginRuntime) {