chore: update eslint (#12226)

Author: Jack-Works

.npmrc

@@ -0,0 +1 @@
+@dimensiondev:registry=https://npm.pkg.github.com/

eslint.config.js

@@ -41,6 +41,7 @@ const avoidMistakeRules = {
     '@tanstack/query/infinite-query-property-order': 'warn', // help TypeScript to infer type correctly
     '@tanstack/query/no-rest-destructuring': 'error',
     '@tanstack/query/no-unstable-deps': 'error', // avoid unstable results from the hook being deps
+    '@tanstack/query/no-void-query-fn': 'error', // query function should always return something
     '@lingui/no-single-tag-to-translate': 'error',
     // '@lingui/no-single-variables-to-translate': 'error', // we're mixing two i18n frameworks, a lot of false positive reports
     // https://github.com/lingui/eslint-plugin/issues/46
@@ -220,7 +221,8 @@ const avoidMistakeRules = {
     'react/no-comment-textnodes': 'warn', // <div>// comment</div> will render text!
     // 'react/no-duplicate-key': 'warn', // <div key={1} /> <div key={1} /> this rule has bug?
     'react/no-leaked-conditional-rendering': 'error', // <div>{0 && <Something />}</div> will render "0"!
-    'react/no-nested-components': 'error', // rerender bugs
+    'react/no-nested-component-definitions': 'error', // rerender bugs
+    'react/no-nested-lazy-component-declarations': 'error', // rerender bugs
     'react-hooks/rules-of-hooks': 'error', // react hooks
     '@typescript-eslint/no-base-to-string': 'error', // prevent buggy .toString() call
     '@typescript-eslint/no-loop-func': 'warn', // capture a loop variable might be a bug
@@ -373,20 +375,22 @@ const codeStyleRules = {
     'prefer-regex-literals': 'warn', // RegEx
     'spaced-comment': ['warn', 'always', { line: { markers: ['/'] } }],
     // 'unicorn/no-array-reduce': 'warn',
-    // 'unicorn/no-array-push-push': 'warn',
     // 'unicorn/no-lonely-if': 'warn', // else if (a) { if (b) expr }
     // 'unicorn/no-negated-condition': 'warn', // if (!a) else
     // 'unicorn/no-nested-ternary': 'warn', // a ? b : c ? d : e
     // 'unicorn/no-typeof-undefined': 'warn', // typeof expr !== 'undefined'
     // 'unicorn/no-unreadable-array-destructuring': 'warn', // [,, foo] = parts
     'unicorn/no-unreadable-iife': 'warn', // (bar => (bar ? bar.baz : baz))(getBar())
+    'unicorn/prefer-import-meta-properties': 'warn',
     // 'unicorn/prefer-negative-index': 'warn',
+    'unicorn/prefer-single-call': 'warn',
     'unicorn/throw-new-error': 'warn',
     // 'unicorn/prefer-logical-operator-over-ternary': 'warn', // prefer ?? and ||
     // 'unicorn/prefer-optional-catch-binding': 'warn', // prefer to omit catch binding
     'react/prefer-shorthand-boolean': 'warn',
     'react/prefer-shorthand-fragment': 'warn',
     '@typescript-eslint/prefer-as-const': 'warn',
+    // '@typescript-eslint/no-unnecessary-type-conversion': 'warn', // for code like str.toString()
 
     // Consistency
     'no-irregular-whitespace': 'warn', // unusual but safe

package.json

@@ -61,8 +61,8 @@
     "@changesets/cli": "^2.28.1",
     "@commitlint/cli": "^19.7.1",
     "@commitlint/config-conventional": "^19.7.1",
-    "@eslint-react/eslint-plugin": "^1.30.2",
-    "@eslint/compat": "^1.2.7",
+    "@eslint-react/eslint-plugin": "^1.49.0",
+    "@eslint/compat": "^1.2.9",
     "@lingui/cli": "^5.2.0",
     "@lingui/swc-plugin": "^5.4.0",
     "@masknet/cli": "workspace:^",
@@ -71,19 +71,19 @@
     "@masknet/typescript-plugin": "workspace:^",
     "@nice-labs/git-rev": "^3.5.1",
     "@swc/core": "1.11.7",
-    "@tanstack/eslint-plugin-query": "^5.66.1",
+    "@tanstack/eslint-plugin-query": "^5.74.7",
     "@types/lodash-es": "^4.17.12",
     "@vitest/ui": "^3.0.7",
     "cspell": "^8.17.5",
-    "eslint": "9.21.0",
+    "eslint": "9.26.0",
     "eslint-formatter-junit": "^8.40.0",
-    "eslint-import-resolver-typescript": "^3.8.3",
+    "eslint-import-resolver-typescript": "^4.3.4",
     "eslint-plugin-i": "^2.29.1",
-    "eslint-plugin-lingui": "^0.10.0",
-    "eslint-plugin-react-compiler": "19.0.0-beta-714736e-20250131",
+    "eslint-plugin-lingui": "^0.10.1",
+    "eslint-plugin-react-compiler": "19.1.0-rc.1",
     "eslint-plugin-react-hooks": "^5.2.0",
     "eslint-plugin-tss-unused-classes": "^1.0.3",
-    "eslint-plugin-unicorn": "^57.0.0",
+    "eslint-plugin-unicorn": "^59.0.1",
     "eslint-plugin-unused-imports": "^4.1.4",
     "gulp": "^5.0.0",
     "husky": "^9.1.7",
@@ -92,7 +92,7 @@
     "prettier": "^3.5.3",
     "svgo": "^3.3.2",
     "typescript": "5.8.2",
-    "typescript-eslint": "^8.26.0",
+    "typescript-eslint": "^8.32.1",
     "vite": "^6.2.0",
     "vitest": "^3.0.7"
   }

packages/backup-format/package.json

@@ -14,7 +14,7 @@
   "dependencies": {
     "@masknet/shared-base": "workspace:^",
     "@msgpack/msgpack": "^3.0.0-beta2",
-    "elliptic": "^6.6.1",
+    "elliptic": "6.6.1",
     "pvtsutils": "^1.3.5"
   },
   "devDependencies": {

packages/gun-utils/package.json

@@ -19,6 +19,6 @@
     "gun": "0.2020.1234"
   },
   "devDependencies": {
-    "@swc/core": "1.9.3"
+    "@swc/core": "1.11.7"
   }
 }

packages/mask/content-script/components/CompositionDialog/CompositionUI.tsx

@@ -154,6 +154,7 @@ export function CompositionDialogUI({ ref, ...props }: CompositionProps) {
     const refItem = useMemo(
         (): CompositionRef => ({
             setMessage: (msg) => {
+                // eslint-disable-next-line react-compiler/react-compiler
                 if (Editor) Editor.value = msg
             },
             setEncryptionKind,

packages/mask/content-script/components/DataSource/useActivatedUI.ts

@@ -1,5 +1,5 @@
 import type { IdentityResolved } from '@masknet/plugin-infra'
-import { MaskMessages, ValueRef, type ProfileInformation } from '@masknet/shared-base'
+import { MaskMessages, ValueRef, type NextIDPersonaBindings, type ProfileInformation } from '@masknet/shared-base'
 import { useValueRef } from '@masknet/shared-base-ui'
 import { NextIDProof } from '@masknet/web3-providers'
 import { FontSize, ThemeColor, ThemeMode, type ThemeSettings } from '@masknet/web3-shared-base'
@@ -60,11 +60,16 @@ export function useCurrentVisitingIdentity() {
     )
 }
 
+interface SocialIdentity extends IdentityResolved {
+    publicKey?: string
+    hasBinding?: boolean
+    binding?: NextIDPersonaBindings
+}
 /**
  * Get the social identity of the given identity
  */
 export function useSocialIdentity(identity: IdentityResolved | null | undefined) {
-    const result = useQuery({
+    const result = useQuery<SocialIdentity | null>({
         enabled: !!identity,
         queryKey: ['social-identity', identity],
         queryFn: async () => {
@@ -86,7 +91,7 @@ export function useSocialIdentity(identity: IdentityResolved | null | undefined)
                     binding: first(personaBindings),
                 }
             } catch {
-                return identity
+                return identity || null
             }
         },
     })
@@ -101,7 +106,7 @@ export function useSocialIdentityByUserId(userId?: string) {
         queryKey: ['social-identity', 'by-id', userId],
         enabled: !!userId,
         queryFn: async () => {
-            return activatedSiteAdaptorUI!.utils.getUserIdentity?.(userId!)
+            return (await activatedSiteAdaptorUI!.utils.getUserIdentity?.(userId!)) || null
         },
         networkMode: 'always',
     })

packages/mask/content-script/components/InjectedComponents/SetupGuide/SetupGuideContext.tsx

@@ -38,7 +38,7 @@ export function useSetupGuideStepInfo(persona?: PersonaIdentifier) {
     useEffect(() => MaskMessages.events.ownPersonaChanged.on(() => refetch()), [])
     const { data: currentTabId } = useQuery({
         queryKey: ['current-tab-id'],
-        queryFn: async () => Services.Helper.getActiveTab().then((x) => x?.id),
+        queryFn: async () => Services.Helper.getActiveTab().then((x) => x?.id || null),
         refetchOnWindowFocus: true,
     })
     const { networkIdentifier: site, configuration } = activatedSiteAdaptorUI!

packages/mask/content-script/site-adaptor-infra/utils/create-post-context.ts

@@ -124,8 +124,7 @@ export function createSiteAdaptorSpecializedPostContext(site: EnhanceableSite, a
                     hasMaskPayload.value = actions.hasPayloadLike(msg)
                 }
                 evaluate()
-                cancel.push(linksSubscribe.subscribe(evaluate))
-                cancel.push(opt.rawMessage.subscribe(evaluate))
+                cancel.push(linksSubscribe.subscribe(evaluate), opt.rawMessage.subscribe(evaluate))
                 return createSubscriptionFromValueRef(hasMaskPayload)
             })(),
             postIVIdentifier: createSubscriptionFromValueRef(postIVIdentifier),

packages/mask/content-script/site-adaptors/twitter.com/injection/ProfileCard/useControlProfileCard.ts

@@ -21,7 +21,6 @@ export function useControlProfileCard(holderRef: RefObject<HTMLDivElement | null
     const hasDialogRef = useRef(false)
     const { stack } = useDialogStacking()
     // TODO: is this the best we can have?
-    // eslint-disable-next-line react-compiler/react-compiler
     hasDialogRef.current = stack.length > 0
 
     const hideProfileCard = useCallback((byClick?: boolean) => {
@@ -44,7 +43,6 @@ export function useControlProfileCard(holderRef: RefObject<HTMLDivElement | null
     }, [])
 
     // TODO: is this the best we can have?
-    // eslint-disable-next-line react-compiler/react-compiler
     if (!holderRef.current) hideProfileCard()
 
     useEffect(() => {