Skip to content

Commit eef1cf5

Browse files
committed
fixup! fix: mf-6508 adjust disconnect notification style
1 parent aad2ebe commit eef1cf5

File tree

3 files changed

+12
-16
lines changed

3 files changed

+12
-16
lines changed

packages/mask/background/services/wallet/services/connect.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,6 @@ export async function getAllConnectedOrigins(wallet: string, type: 'any' | 'sdk'
187187
function assertOrigin(origin: string) {
188188
if (!URL.canParse(origin) || new URL(origin).origin !== origin)
189189
throw new TypeError(
190-
'origin is not a valid origin. See https://developer.mozilla.org/en-US/docs/Glossary/Origin',
190+
`origin ${origin} is not a valid origin. See https://developer.mozilla.org/en-US/docs/Glossary/Origin`,
191191
)
192192
}

packages/mask/popups/hooks/useConnectedOrigins.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,8 @@ export function useConnectedOrigins() {
77
const address = wallet?.address
88
return useQuery({
99
queryKey: ['wallet-granted-origins', address],
10-
queryFn: address ? async () => Services.Wallet.getAllConnectedOrigins(address, 'any') : skipToken,
10+
queryFn: address ? () => Services.Wallet.getAllConnectedOrigins(address, 'any') : skipToken,
1111
enabled: !!address,
1212
networkMode: 'always',
13-
select(data) {
14-
return [...data].sort((a, b) => a.localeCompare(b, 'en-US'))
15-
},
1613
})
1714
}

packages/mask/popups/pages/Wallet/components/DisconnectModal/index.tsx

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { makeStyles, usePopupCustomSnackbar } from '@masknet/theme'
55
import { useWallet } from '@masknet/web3-hooks-base'
66
import { Box, Typography } from '@mui/material'
77
import { useMutation, useQueryClient } from '@tanstack/react-query'
8-
import { memo, useCallback } from 'react'
8+
import { memo } from 'react'
99

1010
const useStyles = makeStyles()((theme) => ({
1111
container: {
@@ -93,13 +93,12 @@ const DisconnectModal = memo(function DisconnectModal({ origin, onClose }: Disco
9393
const queryClient = useQueryClient()
9494
const { classes, cx } = useStyles()
9595
const { showSnackbar } = usePopupCustomSnackbar()
96-
const wallet = useWallet()
97-
const address = wallet?.address
96+
const address = useWallet()?.address
9897
const { mutate: onDisconnect } = useMutation({
99-
mutationFn: useCallback(async (): Promise<void> => {
98+
mutationFn: async (): Promise<void> => {
10099
if (!address) return
101100
await Services.Wallet.disconnectWalletFromOrigin(address, origin, 'any')
102-
}, [address]),
101+
},
103102
onMutate: async () => {
104103
await queryClient.invalidateQueries({ queryKey: ['wallet-granted-origins', address] })
105104
showSnackbar(
@@ -116,10 +115,10 @@ const DisconnectModal = memo(function DisconnectModal({ origin, onClose }: Disco
116115
},
117116
})
118117
const { mutate: onDisconnectAll } = useMutation({
119-
mutationFn: useCallback(async (): Promise<void> => {
120-
if (!wallet) return
118+
mutationFn: async () => {
119+
if (!address) return
121120
await Services.Wallet.disconnectAllOriginsConnectedFromWallet(address!, 'any')
122-
}, [wallet?.address]),
121+
},
123122
onMutate: async () => {
124123
await queryClient.invalidateQueries({ queryKey: ['wallet-granted-origins', address!] })
125124
showSnackbar(
@@ -132,7 +131,7 @@ const DisconnectModal = memo(function DisconnectModal({ origin, onClose }: Disco
132131
onClose()
133132
},
134133
onSettled: () => {
135-
queryClient.invalidateQueries({ queryKey: ['wallet-granted-origins', wallet?.address] })
134+
queryClient.invalidateQueries({ queryKey: ['wallet-granted-origins', address] })
136135
},
137136
})
138137
return (
@@ -150,7 +149,7 @@ const DisconnectModal = memo(function DisconnectModal({ origin, onClose }: Disco
150149
<button
151150
type="button"
152151
className={cx(classes.button, classes.confirmButton)}
153-
disabled={!wallet}
152+
disabled={!address}
154153
onClick={() => onDisconnect()}>
155154
<Trans>Confirm</Trans>
156155
</button>
@@ -161,7 +160,7 @@ const DisconnectModal = memo(function DisconnectModal({ origin, onClose }: Disco
161160
<button
162161
type="button"
163162
className={classes.disconnectAll}
164-
disabled={!wallet}
163+
disabled={!address}
165164
onClick={() => onDisconnectAll()}>
166165
<Trans>Disconnect all accounts</Trans>
167166
</button>

0 commit comments

Comments
 (0)