Skip to content

Commit efe4d00

Browse files
SukkaWJack-Works
andauthored
refactor!: update to eslint v9 (#16)
Co-authored-by: Jack Works <[email protected]>
1 parent 52f9c87 commit efe4d00

34 files changed

+897
-842
lines changed

.changeset/serious-hats-repair.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@masknet/eslint-plugin": minor
3+
---
4+
5+
upgrade to eslint 9

.eslintignore

Lines changed: 0 additions & 3 deletions
This file was deleted.

.eslintrc.json

Lines changed: 28 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,23 @@
1414
"plugin:@typescript-eslint/recommended",
1515
"prettier"
1616
],
17-
"env": { "node": true },
17+
"ignorePatterns": ["lib/**/*", "vitest.config.ts", "estree.tsx"],
18+
"env": {
19+
"node": true
20+
},
1821
"overrides": [
19-
{ "files": ["src/**/*.spec.ts"], "env": { "mocha": true } },
20-
{ "files": ["src/scripts/**/*.ts"], "rules": { "node/shebang": "off" } }
22+
{
23+
"files": ["src/**/*.spec.ts"],
24+
"env": {
25+
"mocha": true
26+
}
27+
},
28+
{
29+
"files": ["src/scripts/**/*.ts"],
30+
"rules": {
31+
"node/shebang": "off"
32+
}
33+
}
2134
],
2235
"rules": {
2336
"constructor-super": "error",
@@ -70,9 +83,18 @@
7083
"error",
7184
{
7285
"paths": [
73-
{ "name": "@typescript-eslint/types/dist/generated/ast-spec", "allowTypeImports": true },
74-
{ "name": "@typescript-eslint/utils/dist/ast-utils", "allowTypeImports": true },
75-
{ "name": "@typescript-eslint/utils/dist/ts-eslint", "allowTypeImports": true }
86+
{
87+
"name": "@typescript-eslint/types/dist/generated/ast-spec",
88+
"allowTypeImports": true
89+
},
90+
{
91+
"name": "@typescript-eslint/utils/dist/ast-utils",
92+
"allowTypeImports": true
93+
},
94+
{
95+
"name": "@typescript-eslint/utils/dist/ts-eslint",
96+
"allowTypeImports": true
97+
}
7698
]
7799
}
78100
]

.github/workflows/check.yml

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -10,40 +10,40 @@ on:
1010

1111
jobs:
1212
prettier:
13-
runs-on: ubuntu-20.04
13+
runs-on: ubuntu-latest
1414
steps:
15-
- uses: actions/checkout@v3
16-
- uses: pnpm/action-setup@v2
17-
- uses: actions/setup-node@v3
15+
- uses: actions/checkout@v4
16+
- uses: pnpm/action-setup@v3
17+
- uses: actions/setup-node@v4
1818
with:
19-
node-version: "19"
20-
- run: pnpx prettier --check .
19+
node-version: "21"
20+
- run: pnpx prettier --check src tests configs
2121
markdownlint:
22-
runs-on: ubuntu-20.04
22+
runs-on: ubuntu-latest
2323
steps:
24-
- uses: actions/checkout@v3
25-
- uses: pnpm/action-setup@v2
26-
- uses: actions/setup-node@v3
24+
- uses: actions/checkout@v4
25+
- uses: pnpm/action-setup@v3
26+
- uses: actions/setup-node@v4
2727
with:
28-
node-version: "19"
28+
node-version: "21"
2929
- run: pnpx markdownlint-cli .
3030
spellcheck:
31-
runs-on: ubuntu-20.04
31+
runs-on: ubuntu-latest
3232
steps:
33-
- uses: actions/checkout@v3
34-
- uses: pnpm/action-setup@v2
35-
- uses: actions/setup-node@v3
33+
- uses: actions/checkout@v4
34+
- uses: pnpm/action-setup@v3
35+
- uses: actions/setup-node@v4
3636
with:
37-
node-version: "19"
37+
node-version: "21"
3838
- run: pnpx cspell lint --relative --no-progress '**'
3939
test:
40-
runs-on: ubuntu-20.04
40+
runs-on: ubuntu-latest
4141
steps:
42-
- uses: actions/checkout@v3
43-
- uses: pnpm/action-setup@v2
44-
- uses: actions/setup-node@v3
42+
- uses: actions/checkout@v4
43+
- uses: pnpm/action-setup@v3
44+
- uses: actions/setup-node@v4
4545
with:
46-
node-version: "19"
46+
node-version: "21"
4747
cache: "pnpm"
4848
- run: pnpm install
4949
- run: pnpm run lint

.github/workflows/publish.yml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,29 +10,28 @@ on:
1010

1111
jobs:
1212
publish:
13-
runs-on: ubuntu-20.04
13+
runs-on: ubuntu-latest
1414
permissions:
1515
pull-requests: write
1616
contents: write
1717
id-token: write
1818
steps:
19-
- uses: actions/checkout@v3
19+
- uses: actions/checkout@v4
2020
with:
2121
fetch-depth: 0
22-
- uses: pnpm/action-setup@v2
23-
- uses: actions/setup-node@v3
22+
- uses: pnpm/action-setup@v3
23+
- uses: actions/setup-node@v4
2424
with:
2525
node-version: "19"
2626
cache: "pnpm"
2727
- run: pnpm install
2828
- run: pnpm run generate
29-
- run: npx tsc -b
30-
- run: npm install -g npm
29+
- run: pnpm --package=typescript dlx tsc -b
3130
- uses: changesets/action@v1
3231
with:
3332
title: "ci: draft a new release"
3433
commit: "ci: draft a new release"
35-
publish: npx changeset publish
34+
publish: pnpx @changesets/cli publish
3635
env:
3736
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3837
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

package.json

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
],
4141
"scripts": {
4242
"generate": "node --loader ts-node/esm/transpile-only ./src/scripts/generate/index.ts",
43-
"lint": "eslint . --fix",
43+
"lint": "ESLINT_USE_FLAT_CONFIG=false eslint . --fix",
4444
"markdownlint": "markdownlint .",
4545
"prepare": "husky install",
4646
"spellcheck": "cspell lint --relative --no-progress '**'",
@@ -55,32 +55,33 @@
5555
},
5656
"devDependencies": {
5757
"@changesets/cli": "^2.27.1",
58-
"@commitlint/config-conventional": "^18.6.0",
58+
"@commitlint/config-conventional": "^19.2.2",
5959
"@masknet/config": "^0.2.1",
6060
"@types/glob": "^8.1.0",
6161
"@types/prettier": "^3.0.0",
62-
"@typescript-eslint/eslint-plugin": "^6.21.0",
63-
"@typescript-eslint/parser": "^6.21.0",
64-
"@typescript-eslint/types": "^6.21.0",
65-
"@typescript-eslint/utils": "^6.21.0",
66-
"commitlint": "^18.6.0",
67-
"cspell": "^8.3.2",
68-
"eslint": "^8.56.0",
62+
"@typescript-eslint/eslint-plugin": "^7.6.0",
63+
"@typescript-eslint/parser": "^7.6.0",
64+
"@typescript-eslint/types": "^7.6.0",
65+
"@typescript-eslint/utils": "^7.6.0",
66+
"commitlint": "^19.2.2",
67+
"cspell": "^8.7.0",
68+
"eslint": "^9.0.0",
6969
"eslint-config-prettier": "^9.1.0",
70-
"eslint-plugin-eslint-plugin": "^5.3.0",
70+
"eslint-plugin-eslint-plugin": "^6.0.0",
7171
"eslint-plugin-import": "^2.29.1",
72-
"eslint-plugin-unicorn": "^51.0.1",
73-
"eslint-plugin-unused-imports": "^3.0.0",
74-
"glob": "^10.3.10",
75-
"husky": "^9.0.10",
72+
"eslint-plugin-unicorn": "^52.0.0",
73+
"eslint-plugin-unused-imports": "^3.1.0",
74+
"glob": "^10.3.12",
75+
"globals": "^15.0.0",
76+
"husky": "^9.0.11",
7677
"json-schema-to-typescript": "^13.1.2",
7778
"lint-staged": "^15.2.2",
7879
"markdownlint-cli": "^0.39.0",
7980
"prettier": "^3.2.5",
8081
"ts-dedent": "^2.2.0",
8182
"ts-node": "^10.9.2",
82-
"typescript": "^5.3.3",
83-
"vitest": "^1.2.2"
83+
"typescript": "^5.4.5",
84+
"vitest": "^1.5.0"
8485
},
8586
"peerDependencies": {
8687
"eslint": ">= 8"

0 commit comments

Comments
 (0)