[-] Select: CI tests fixed (clippy, doc, PW).

Author: npatsakula

playwright/select.spec.ts

@@ -1,60 +1,62 @@
-import { test, expect } from '@playwright/test';
-
-test('test', async ({ page }) => {
-  await page.goto('http://127.0.0.1:8080/component/?name=select&', { timeout: 20 * 60 * 1000 }); // Increase timeout to 20 minutes
-  // Find Select a fruit...
-  let selectTrigger = page.locator(".select-trigger");
-  await selectTrigger.click();
-  // Assert the select menu is open
-  const selectMenu = page.locator('.select-list');
-  await expect(selectMenu).toHaveAttribute('data-state', 'open');
-
-  // Assert the menu is focused
-  await expect(selectMenu).toBeFocused();
-  await page.keyboard.press('ArrowDown');
-  const firstOption = selectMenu.getByRole('option', { name: 'apple' });
-  await expect(firstOption).toBeFocused();
-
-  // Assert moving down with arrow keys moves focus to the next option
-  await page.keyboard.press('ArrowDown');
-  const secondOption = selectMenu.getByRole('option', { name: 'banana' });
-  await expect(secondOption).toBeFocused();
-
-  // Assert moving up with arrow keys moves focus back to the previous option
-  await page.keyboard.press('ArrowUp');
-  await expect(firstOption).toBeFocused();
-
-  // Assert pressing Enter selects the focused option
-  await page.keyboard.press('Enter');
-  // Assert the select menu is closed after selection
-  await expect(selectMenu).toHaveCount(0);
-
-  // Assert the selected value is displayed in the button
-  await expect(selectTrigger).toHaveText('apple');
-
-  // Reopen the select menu
-  await selectTrigger.click();
-
-  // Assert typeahead functionality works
-  await page.keyboard.type('Ban');
-  // Assert the second option is focused after typing 'Ban'
-  await expect(secondOption).toBeFocused();
-
-  // Assert pressing Escape closes the select menu
-  await page.keyboard.press('Escape');
-  // Assert the select menu is closed
-  await expect(selectMenu).toHaveCount(0);
-
-  // Reopen the select menu
-  await selectTrigger.click();
-  // Assert the select menu is open again
-  await expect(selectMenu).toHaveAttribute('data-state', 'open');
-
-  // Click the second option to select it
-  let bananaOption = selectMenu.getByRole('option', { name: 'banana' });
-  await bananaOption.click();
-  // Assert the select menu is closed after clicking an option
-  await expect(selectMenu).toHaveCount(0);
-  // Assert the selected value is now 'banana'
-  await expect(selectTrigger).toHaveText('banana');
+import { test, expect } from "@playwright/test";
+
+test("test", async ({ page }) => {
+    await page.goto("http://127.0.0.1:8080/component/?name=select&", {
+        timeout: 20 * 60 * 1000,
+    }); // Increase timeout to 20 minutes
+    // Find Select a fruit...
+    let selectTrigger = page.locator(".select-trigger");
+    await selectTrigger.click();
+    // Assert the select menu is open
+    const selectMenu = page.locator(".select-list");
+    await expect(selectMenu).toHaveAttribute("data-state", "open");
+
+    // Assert the menu is focused
+    await expect(selectMenu).toBeFocused();
+    await page.keyboard.press("ArrowDown");
+    const firstOption = selectMenu.getByRole("option", { name: "apple" });
+    await expect(firstOption).toBeFocused();
+
+    // Assert moving down with arrow keys moves focus to the next option
+    await page.keyboard.press("ArrowDown");
+    const secondOption = selectMenu.getByRole("option", { name: "banana" });
+    await expect(secondOption).toBeFocused();
+
+    // Assert moving up with arrow keys moves focus back to the previous option
+    await page.keyboard.press("ArrowUp");
+    await expect(firstOption).toBeFocused();
+
+    // Assert pressing Enter selects the focused option
+    await page.keyboard.press("Enter");
+    // Assert the select menu is closed after selection
+    await expect(selectMenu).toHaveCount(0);
+
+    // Assert the selected value is displayed in the button
+    await expect(selectTrigger).toHaveText("Apple");
+
+    // Reopen the select menu
+    await selectTrigger.click();
+
+    // Assert typeahead functionality works
+    await page.keyboard.type("Ban");
+    // Assert the second option is focused after typing 'Ban'
+    await expect(secondOption).toBeFocused();
+
+    // Assert pressing Escape closes the select menu
+    await page.keyboard.press("Escape");
+    // Assert the select menu is closed
+    await expect(selectMenu).toHaveCount(0);
+
+    // Reopen the select menu
+    await selectTrigger.click();
+    // Assert the select menu is open again
+    await expect(selectMenu).toHaveAttribute("data-state", "open");
+
+    // Click the second option to select it
+    let bananaOption = selectMenu.getByRole("option", { name: "banana" });
+    await bananaOption.click();
+    // Assert the select menu is closed after clicking an option
+    await expect(selectMenu).toHaveCount(0);
+    // Assert the selected value is now 'banana'
+    await expect(selectTrigger).toHaveText("Banana");
 });

primitives/src/select/components/group.rs

@@ -26,9 +26,9 @@ pub struct SelectGroupProps {
 
 /// # SelectGroup
 ///
-/// The `SelectGroup` component is used to group related options within a [`SelectList`]. It provides a way to organize options into logical sections.
+/// The `SelectGroup` component is used to group related options within a [`SelectList`](super::list::SelectList). It provides a way to organize options into logical sections.
 ///
-/// This must be used inside a [`SelectList`] component.
+/// This must be used inside a [`SelectList`](super::list::SelectList) component.
 #[component]
 pub fn SelectGroup<T: Clone + PartialEq + 'static>(props: SelectGroupProps) -> Element {
     let ctx = use_context::<SelectContext<T>>();
@@ -68,9 +68,9 @@ pub struct SelectGroupLabelProps {
 
 /// # SelectGroupLabel
 ///
-/// The `SelectGroupLabel` component is used to render a label for a group of options within a [`SelectList`].
+/// The `SelectGroupLabel` component is used to render a label for a group of options within a [`SelectList`](super::list::SelectList).
 ///
-/// This must be used inside a [`SelectGroup`] component.
+/// This must be used inside a [`SelectGroup`](SelectGroup) component.
 #[component]
 pub fn SelectGroupLabel(props: SelectGroupLabelProps) -> Element {
     let mut ctx: SelectGroupContext = use_context();

primitives/src/select/components/list.rs

@@ -22,10 +22,10 @@ pub struct SelectListProps {
 
 /// # SelectList
 ///
-/// The dropdown list container for the [`Select`] component that contains the
-/// [`SelectOption`]s. The list will only be rendered when the select is open.
+/// The dropdown list container for the [`Select`](super::select::Select) component that contains the
+/// [`SelectOption`](super::option::SelectOption)s. The list will only be rendered when the select is open.
 ///
-/// This must be used inside a [`Select`] component.
+/// This must be used inside a [`Select`](super::select::Select) component.
 #[component]
 pub fn SelectList<T: Clone + PartialEq + 'static>(props: SelectListProps) -> Element {
     let mut ctx = use_context::<SelectContext<T>>();

primitives/src/select/components/option.rs

@@ -44,7 +44,7 @@ pub struct SelectOptionProps<T: Clone + PartialEq + 'static> {
 
 /// # SelectOption
 ///
-/// An individual selectable option within a [`SelectList`] component. Each option represents
+/// An individual selectable option within a [`SelectList`](super::list::SelectList) component. Each option represents
 /// a value that can be selected.
 ///
 /// ## Value vs Display
@@ -54,7 +54,7 @@ pub struct SelectOptionProps<T: Clone + PartialEq + 'static> {
 ///
 /// If `display` is not provided, the `value` will be formatted and used as the display text.
 ///
-/// This must be used inside a [`SelectList`] component.
+/// This must be used inside a [`SelectList`](super::list::SelectList) component.
 #[component]
 pub fn SelectOption<T: PartialEq + Clone + 'static>(props: SelectOptionProps<T>) -> Element {
     // Generate a unique ID for this option for accessibility
@@ -136,10 +136,10 @@ pub struct SelectItemIndicatorProps {
 
 /// # SelectItemIndicator
 ///
-/// The `SelectItemIndicator` component is used to render an indicator for a selected item within a [`SelectList`]. The
+/// The `SelectItemIndicator` component is used to render an indicator for a selected item within a [`SelectList`](super::list::SelectList). The
 /// children will only be rendered if the option is selected.
 ///
-/// This must be used inside a [`SelectOption`] component.
+/// This must be used inside a [`SelectOption`](SelectOption) component.
 #[component]
 pub fn SelectItemIndicator(props: SelectItemIndicatorProps) -> Element {
     let ctx: SelectOptionContext = use_context();

primitives/src/select/components/trigger.rs

@@ -17,9 +17,9 @@ pub struct SelectTriggerProps {
 
 /// # SelectTrigger
 ///
-/// The trigger button for the [`Select`] component which controls if the [`SelectList`] is rendered.
+/// The trigger button for the [`Select`](super::select::Select) component which controls if the [`SelectList`](super::list::SelectList) is rendered.
 ///
-/// This must be used inside a [`Select`] component.
+/// This must be used inside a [`Select`](super::select::Select) component.
 #[component]
 pub fn SelectTrigger<T: Clone + PartialEq + 'static>(props: SelectTriggerProps) -> Element {
     let mut ctx = use_context::<SelectContext<T>>();

primitives/src/select/mod.rs

@@ -118,7 +118,7 @@
 
 // Internal modules
 mod context;
-mod text_search;
+pub(crate) mod text_search;
 
 // Public components module
 pub mod components;

primitives/src/select/text_search.rs

@@ -178,7 +178,7 @@ impl AdaptiveKeyboard {
         let key_b = self.physical_mappings.iter().find(|(_, &ch)| ch == b)?.0;
 
         let distance = physical_key_distance(key_a, key_b)?;
-        Some((distance / 10.0).min(1.0).max(0.1))
+        Some((distance / 10.0).clamp(0.1, 1.0))
     }
 
     /// Calculate similarity based on Unicode codepoint proximity
@@ -187,7 +187,7 @@ impl AdaptiveKeyboard {
 
         // Characters close in Unicode are often similar
         // Scale: adjacent codepoints get ~0.1 cost, distant ones approach 1.0
-        (diff / 100.0).min(1.0).max(0.1)
+        (diff / 100.0).clamp(0.1, 1.0)
     }
 
     /// Check phonetic similarity using small lookup groups
@@ -387,7 +387,7 @@ impl KeyboardLayout {
         let distance = (dx * dx + dy * dy).sqrt();
 
         // Scale the distance to be between 0.1 and 1.0
-        (distance / 10.0).min(1.0).max(0.1)
+        (distance / 10.0).clamp(0.1, 1.0)
     }
 
     /// Get the position of a character on the keyboard layout