Skip to content

Apply all subsecond handlers asynchronously on wasm32 #4904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Apply all subsecond handlers asynchronously on wasm32 #4904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions packages/subsecond/subsecond/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,14 +310,24 @@ unsafe fn commit_patch(table: JumpTable) {
Box::into_raw(Box::new(table)),
std::sync::atomic::Ordering::Relaxed,
);
HOTRELOAD_HANDLERS
.lock()
.unwrap()
.clone()
.iter()
.for_each(|handler| {
let handlers = HOTRELOAD_HANDLERS.lock().unwrap().clone();

#[cfg(target_arch = "wasm32")]
{
for handler in handlers {
// run after the current Task::run has unwound
wasm_bindgen_futures::spawn_local(async move {
handler();
});
}
}

#[cfg(not(target_arch = "wasm32"))]
{
for handler in handlers {
handler();
});
}
}
}

/// A panic issued by the [`call`] function if the caller would be stale if called. This causes
Expand Down
Loading