Skip to content

Commit b2b6183

Browse files
authored
Merge pull request #91 from DirectoryTree/fix-flag-method-signature
Fix `flag()` method signature
2 parents 828ccbf + 5a93152 commit b2b6183

File tree

5 files changed

+8
-5
lines changed

5 files changed

+8
-5
lines changed

src/FileMessage.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
namespace DirectoryTree\ImapEngine;
44

5+
use BackedEnum;
56
use BadMethodCallException;
67

78
class FileMessage implements MessageInterface
@@ -26,7 +27,7 @@ public function uid(): int
2627
/**
2728
* {@inheritDoc}
2829
*/
29-
public function flag(mixed $flag, string $operation, bool $expunge = false): void
30+
public function flag(BackedEnum|string $flag, string $operation, bool $expunge = false): void
3031
{
3132
throw new BadMethodCallException('FileMessage does not support flagging');
3233
}

src/FlaggableInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,5 +121,5 @@ public function hasFlag(BackedEnum|string $flag): bool;
121121
/**
122122
* Add or remove a flag from the message.
123123
*/
124-
public function flag(mixed $flag, string $operation, bool $expunge = false): void;
124+
public function flag(BackedEnum|string $flag, string $operation, bool $expunge = false): void;
125125
}

src/HasFlags.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,5 +184,5 @@ abstract public function flags(): array;
184184
/**
185185
* {@inheritDoc}
186186
*/
187-
abstract public function flag(mixed $flag, string $operation, bool $expunge = false): void;
187+
abstract public function flag(BackedEnum|string $flag, string $operation, bool $expunge = false): void;
188188
}

src/Message.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
namespace DirectoryTree\ImapEngine;
44

5+
use BackedEnum;
56
use DirectoryTree\ImapEngine\Connection\Responses\MessageResponseParser;
67
use DirectoryTree\ImapEngine\Exceptions\ImapCapabilityException;
78
use DirectoryTree\ImapEngine\Support\Str;
@@ -103,7 +104,7 @@ public function is(MessageInterface $message): bool
103104
/**
104105
* Add or remove a flag from the message.
105106
*/
106-
public function flag(mixed $flag, string $operation, bool $expunge = false): void
107+
public function flag(BackedEnum|string $flag, string $operation, bool $expunge = false): void
107108
{
108109
$flag = Str::enum($flag);
109110

src/Testing/FakeMessage.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
namespace DirectoryTree\ImapEngine\Testing;
44

5+
use BackedEnum;
56
use DirectoryTree\ImapEngine\HasFlags;
67
use DirectoryTree\ImapEngine\HasParsedMessage;
78
use DirectoryTree\ImapEngine\MessageInterface;
@@ -42,7 +43,7 @@ public function is(MessageInterface $message): bool
4243
/**
4344
* {@inheritDoc}
4445
*/
45-
public function flag(mixed $flag, string $operation, bool $expunge = false): void
46+
public function flag(BackedEnum|string $flag, string $operation, bool $expunge = false): void
4647
{
4748
$flag = Str::enum($flag);
4849

0 commit comments

Comments
 (0)