Skip to content

Commit 19a116f

Browse files
committed
Remove unnecessary glue argument from implode calls
1 parent a52d026 commit 19a116f

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

src/Models/Attributes/TSProperty.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ protected function packBitString(string $bits, int $len): string
282282
$nibbles[$i] = base_convert($nibble, 2, 16);
283283
}
284284

285-
return pack('H*', implode('', $nibbles));
285+
return pack('H*', implode($nibbles));
286286
}
287287

288288
/**

src/Query/Filter/AndGroup.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public function getOperator(): string
4242
*/
4343
public function getRaw(): string
4444
{
45-
return '&'.implode('', array_map(fn (Filter $filter) => (string) $filter, $this->filters));
45+
return '&'.implode(array_map(fn (Filter $filter) => (string) $filter, $this->filters));
4646
}
4747

4848
/**

src/Query/Filter/OrGroup.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public function getOperator(): string
4242
*/
4343
public function getRaw(): string
4444
{
45-
return '|'.implode('', array_map(fn (Filter $filter) => (string) $filter, $this->filters));
45+
return '|'.implode(array_map(fn (Filter $filter) => (string) $filter, $this->filters));
4646
}
4747

4848
/**

src/Query/Filter/Parser.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ protected static function match(string $string): array
4848
*/
4949
public static function assemble(Filter|array $filters = []): string
5050
{
51-
return implode('', array_map(
51+
return implode(array_map(
5252
fn (Filter $filter) => (string) $filter,
5353
Arr::wrap($filters)
5454
));

tests/Unit/Models/ModelRelationTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ public function test_has_many_foreign_values_are_properly_escaped_for_use_in_fil
222222

223223
$model = new ModelWithHasManyRelationTestStub;
224224

225-
$characters = implode('', array_merge($escapedDnCharacters, $escapedFilterCharacters));
225+
$characters = implode(array_merge($escapedDnCharacters, $escapedFilterCharacters));
226226

227227
$model->setDn($characters);
228228

0 commit comments

Comments
 (0)