Merge pull request #608 from bonroyage/2.x/case-insensitive-dn-comparison

[2.x] Case insensitive DN comparison

Author: stevebauman

src/Models/Collection.php

@@ -109,8 +109,8 @@ protected function compareModelWithRelated($model, $related)
     {
         if (is_string($model)) {
             return $this->isValidDn($model)
-                ? $related->getDn() == $model
-                : $related->getName() == $model;
+                ? strcasecmp($related->getDn(), $model) === 0
+                : strcasecmp($related->getName(), $model) === 0;
         }
 
         return $related->is($model);

tests/Unit/Models/ModelRelationTest.php

@@ -128,11 +128,13 @@ public function test_exists()
         $this->assertTrue($relation->exists($related->newCollection([$related])));
         $this->assertTrue($relation->exists('foo'));
         $this->assertTrue($relation->exists('cn=foo,dc=local,dc=com'));
+        $this->assertTrue($relation->exists('CN=foo,DC=local,DC=com'));
 
         $this->assertFalse($relation->exists(null));
         $this->assertFalse($relation->exists($unrelated->newCollection([$unrelated])));
         $this->assertFalse($relation->exists([$related, $unrelated]));
         $this->assertFalse($relation->exists(['cn=foo,dc=local,dc=com', 'cn=bar,dc=local,dc=com']));
+        $this->assertFalse($relation->exists(['CN=foo,DC=local,DC=com', 'CN=bar,DC=local,DC=com']));
         $this->assertFalse($relation->exists('bar'));
     }