Refactor tests to use Pest's artisan helper

Author: stevebauman

tests/Commands/CommitMetricsTest.php

@@ -11,6 +11,8 @@
 use Illuminate\Support\Facades\Queue;
 use Illuminate\Support\Facades\Redis;
 
+use function Pest\Laravel\artisan;
+
 beforeEach(function () {
     Queue::fake();
     Redis::flushdb();
@@ -19,7 +21,7 @@
 });
 
 it('displays message when no metrics to commit', function () {
-    $this->artisan(CommitMetrics::class)
+    artisan(CommitMetrics::class)
         ->expectsOutput('No metrics to commit.')
         ->assertSuccessful();
 
@@ -34,7 +36,7 @@
 
     expect(Metric::count())->toBe(0);
 
-    $this->artisan(CommitMetrics::class)
+    artisan(CommitMetrics::class)
         ->expectsOutput('Committed 2 metric(s).')
         ->assertSuccessful();
 
@@ -52,7 +54,7 @@
     Metrics::record(new MetricData('page_views'));
     Metrics::record(new MetricData('api_calls'));
 
-    $this->artisan(CommitMetrics::class)
+    artisan(CommitMetrics::class)
         ->expectsOutput('Committed 2 metric(s).')
         ->assertSuccessful();
 
@@ -65,7 +67,7 @@
     Metrics::capture();
     Metrics::record(new MetricData('page_views'));
 
-    $this->artisan(CommitMetrics::class)
+    artisan(CommitMetrics::class)
         ->expectsOutput('Committed 1 metric(s).')
         ->assertSuccessful();
 
@@ -78,7 +80,7 @@
     Metrics::record(new MetricData('api_calls'));
     Metrics::record(new MetricData('logins'));
 
-    $this->artisan(CommitMetrics::class)
+    artisan(CommitMetrics::class)
         ->expectsOutput('Committed 3 metric(s).')
         ->assertSuccessful();
 
@@ -89,13 +91,13 @@
     Metrics::capture();
     Metrics::record(new MetricData('page_views'));
 
-    $this->artisan(CommitMetrics::class)
+    artisan(CommitMetrics::class)
         ->assertSuccessful();
 
     expect(Metric::count())->toBe(1);
 
     // Running again should show no metrics
-    $this->artisan(CommitMetrics::class)
+    artisan(CommitMetrics::class)
         ->expectsOutput('No metrics to commit.')
         ->assertSuccessful();
 
@@ -108,7 +110,7 @@
     Metrics::record(new MetricData('page_views', 'analytics'));
     Metrics::record(new MetricData('api_calls'));
 
-    $this->artisan(CommitMetrics::class)
+    artisan(CommitMetrics::class)
         ->expectsOutput('Committed 3 metric(s).')
         ->assertSuccessful();
 
@@ -127,7 +129,7 @@
     Metrics::record(new MetricData('logins', measurable: $user2));
     Metrics::record(new MetricData('logins'));
 
-    $this->artisan(CommitMetrics::class)
+    artisan(CommitMetrics::class)
         ->expectsOutput('Committed 3 metric(s).')
         ->assertSuccessful();
 
@@ -144,7 +146,7 @@
         Metrics::record(new MetricData('page_views'));
     }
 
-    $this->artisan(CommitMetrics::class)
+    artisan(CommitMetrics::class)
         ->expectsOutput('Committed 1 metric(s).')
         ->assertSuccessful();
 
@@ -156,13 +158,13 @@
     Metrics::capture();
     Metrics::record(new MetricData('page_views'));
 
-    $this->artisan(CommitMetrics::class)
+    artisan(CommitMetrics::class)
         ->expectsOutput('Committed 1 metric(s).')
         ->assertSuccessful();
 
     Metrics::record(new MetricData('api_calls'));
 
-    $this->artisan(CommitMetrics::class)
+    artisan(CommitMetrics::class)
         ->expectsOutput('Committed 1 metric(s).')
         ->assertSuccessful();
 
@@ -173,7 +175,7 @@
     // Record without capturing
     Metrics::record(new MetricData('page_views'));
 
-    $this->artisan(CommitMetrics::class)
+    artisan(CommitMetrics::class)
         ->expectsOutput('No metrics to commit.')
         ->assertSuccessful();
 
@@ -187,7 +189,7 @@
     Metrics::record(new MetricData('revenue', value: 250));
     Metrics::record(new MetricData('revenue', value: 50));
 
-    $this->artisan(CommitMetrics::class)
+    artisan(CommitMetrics::class)
         ->expectsOutput('Committed 1 metric(s).')
         ->assertSuccessful();
 
@@ -203,7 +205,7 @@
     Metrics::record(new MetricData('page_views', date: $today));
     Metrics::record(new MetricData('page_views', date: $yesterday));
 
-    $this->artisan(CommitMetrics::class)
+    artisan(CommitMetrics::class)
         ->expectsOutput('Committed 2 metric(s).')
         ->assertSuccessful();
 
@@ -217,7 +219,7 @@
     Metrics::capture();
     Metrics::record(new MetricData('page_views', 'marketing', value: 5, date: $date, measurable: $user));
 
-    $this->artisan(CommitMetrics::class)
+    artisan(CommitMetrics::class)
         ->expectsOutput('Committed 1 metric(s).')
         ->assertSuccessful();
 
@@ -242,7 +244,7 @@
     Metrics::record(new MetricData('page_views'));
     Metrics::record(new MetricData('api_calls'));
 
-    $this->artisan(CommitMetrics::class)
+    artisan(CommitMetrics::class)
         ->expectsOutput('Committed 2 metric(s).')
         ->assertSuccessful();