Merge pull request #10 from DirectoryTree/bug-9

Fix MetricFake::commit clearing recorded metrics

Author: stevebauman

src/MetricFake.php

@@ -33,11 +33,7 @@ public function record(Measurable $metric): void
      */
     public function commit(): int
     {
-        $count = count($this->recorded);
-
-        $this->recorded = [];
-
-        return $count;
+        return count($this->recorded);
     }
 
     /**

tests/MetricFakeTest.php

@@ -123,17 +123,18 @@
     expect($recorded->count())->toBe(2);
 });
 
-it('commit clears recorded metrics', function () {
+it('commit returns count of recorded metrics', function () {
     $fake = new MetricFake;
 
     $fake->record(new MetricData('page_views'));
     $fake->record(new MetricData('api_calls'));
 
     expect($fake->recorded()->count())->toBe(2);
 
-    $fake->commit();
+    $count = $fake->commit();
 
-    expect($fake->recorded()->count())->toBe(0);
+    expect($count)->toBe(2)
+        ->and($fake->recorded()->count())->toBe(2);
 });
 
 it('can start capturing', function () {
@@ -245,13 +246,15 @@
     $fake = new MetricFake;
 
     $fake->record(new MetricData('page_views'));
-    $fake->commit();
 
-    expect($fake->recorded()->count())->toBe(0);
+    $count = $fake->commit();
+
+    expect($count)->toBe(1)
+        ->and($fake->recorded()->count())->toBe(1);
 
     $fake->record(new MetricData('api_calls'));
 
-    expect($fake->recorded()->count())->toBe(1);
+    expect($fake->recorded()->count())->toBe(2);
 });
 
 it('assertion fails when metric not recorded', function () {