cur progress addressing PR comments

Author: trangdoan982

apps/roam/src/components/ModifyNodeDialog.tsx

@@ -178,7 +178,13 @@ const ModifyNodeDialog = ({
         }
       } catch (error) {
         if (contentRequestIdRef.current === req && alive) {
-          console.error("Error fetching content options:", error);
+          renderToast({
+            id: `discourse-node-error-${Date.now()}`,
+            intent: "danger",
+            content: (
+              <span>Error fetching content options: {String(error)}</span>
+            ),
+          });
         }
       } finally {
         if (contentRequestIdRef.current === req && alive) {
@@ -313,7 +319,6 @@ const ModifyNodeDialog = ({
             nodeType: selectedNodeType.type,
             blockUid: sourceBlockUid,
           });
-          console.log("formattedTitle", formattedTitle);
         }
         if (!formattedTitle) {
           return;

apps/roam/src/components/canvas/DiscourseNodeUtil.tsx

@@ -46,7 +46,7 @@ import {
 import { getSetting } from "~/utils/extensionSettings";
 import DiscourseContextOverlay from "~/components/DiscourseContextOverlay";
 import { getDiscourseNodeColors } from "~/utils/getDiscourseNodeColors";
-import { OnloadArgs } from "roamjs-components/types";
+import { render as renderToast } from "roamjs-components/components/Toast";
 
 // TODO REPLACE WITH TLDRAW DEFAULTS
 // https://github.com/tldraw/tldraw/pull/1580/files
@@ -555,10 +555,13 @@ export class BaseDiscourseNodeUtil extends ShapeUtil<DiscourseNodeShape> {
                   finalUid,
                 });
               } catch (error) {
-                console.error(
-                  "[DiscourseNodeUtil] Error creating relations:",
-                  error,
-                );
+                renderToast({
+                  id: `discourse-node-error-${Date.now()}`,
+                  intent: "danger",
+                  content: (
+                    <span>Error creating relations: {String(error)}</span>
+                  ),
+                });
               }
             }
 

apps/roam/src/components/canvas/uiOverrides.tsx

@@ -152,10 +152,8 @@ export const getOnSelectForShape = ({
         imageUrl: src,
         onSuccess: async ({ text, uid, newPageUid }) => {
           const finalUid = newPageUid || uid;
-          // Delete the original image shape
           editor.deleteShapes([shape.id]);
 
-          // Create the discourse node shape
           const { h, w, imageUrl } = await calcCanvasNodeSizeAndImg({
             nodeText: text,
             extensionAPI,

apps/roam/src/utils/formatUtils.ts

@@ -6,8 +6,6 @@ import getDiscourseNodes, { DiscourseNode } from "./getDiscourseNodes";
 import compileDatalog from "./compileDatalog";
 import discourseNodeFormatToDatalog from "./discourseNodeFormatToDatalog";
 import createOverlayRender from "roamjs-components/util/createOverlayRender";
-import { render as renderToast } from "roamjs-components/components/Toast";
-import FormDialog from "roamjs-components/components/FormDialog";
 import { QBClause, Result } from "./types";
 import findDiscourseNode from "./findDiscourseNode";
 import extractTag from "roamjs-components/util/extractTag";