Refactor ResultsTable to streamline link rendering and remove CellLink component

- Removed the CellLink component and integrated its functionality directly into ResultRow for improved clarity.
- Updated link rendering logic to handle both 'link' and 'alias' views more efficiently.
- Simplified event handling for link interactions, enhancing overall performance.

Author: mdroidian

apps/roam/src/components/results-view/ResultsTable.tsx

@@ -240,55 +240,6 @@ export const CellRender = ({
   return <span ref={contentRef} className="roamjs-query-link-cell" />;
 };
 
-export const CellLink = ({
-  content,
-  uid,
-  url,
-  ctrlClick,
-}: {
-  content: string;
-  uid: string;
-  url?: string;
-  ctrlClick?: (e: { text: string; uid: string }) => void;
-}) => {
-  const pageTitle = getPageTitleByPageUid(uid);
-  return (
-    <a
-      className={"rm-page-ref"}
-      data-link-title={pageTitle || ""}
-      href={url || getRoamUrl(uid)}
-      onMouseDown={(e) => {
-        if (e.shiftKey) {
-          void openBlockInSidebar(uid);
-          e.preventDefault();
-          e.stopPropagation();
-        } else if (e.ctrlKey && ctrlClick) {
-          ctrlClick({
-            text: content,
-            uid,
-          });
-          e.preventDefault();
-          e.stopPropagation();
-        }
-      }}
-      onClick={(e) => {
-        if (e.shiftKey || e.ctrlKey) {
-          e.preventDefault();
-          e.stopPropagation();
-        }
-      }}
-      onContextMenu={(e) => {
-        if (e.ctrlKey) {
-          e.preventDefault();
-          e.stopPropagation();
-        }
-      }}
-    >
-      {content}
-    </a>
-  );
-};
-
 type ResultRowProps = {
   r: Result;
   columns: Column[];
@@ -441,16 +392,9 @@ const ResultRow = ({
             >
               {val === "" ? (
                 <i>[block is blank]</i>
-              ) : view === "link" ? (
-                <CellLink
-                  content={val.toString()}
-                  uid={uid}
-                  url={(r[`${key}-url`] as string) || undefined}
-                  ctrlClick={ctrlClick}
-                />
               ) : view === "render" ? (
                 <CellRender content={val.toString()} uid={uid} />
-              ) : view === "alias" ? (
+              ) : view === "link" || view === "alias" ? (
                 <a
                   className={"rm-page-ref"}
                   data-link-title={getPageTitleByPageUid(uid) || ""}
@@ -482,7 +426,7 @@ const ResultRow = ({
                     }
                   }}
                 >
-                  {viewValue}
+                  {view === "alias" ? viewValue : cell(key)}
                 </a>
               ) : view === "embed" ? (
                 <CellEmbed uid={uid} viewValue={viewValue} />