Refactor Export components to use getSetting for consistent settings retrieval

- Updated ExportDialog and ExportGithub components to replace localStorageGet with getSetting for fetching GitHub OAuth and repository settings.
- Modified extensionSettings utility functions to use arrow functions and provide a default value for getSetting.
- Improved code readability and maintainability by standardizing the method of accessing settings.

Author: mdroidian

apps/roam/src/components/Export.tsx

@@ -119,7 +119,7 @@ const ExportDialog: ExportDialogComponent = ({
   initialExportDestination,
 }) => {
   const [selectedRepo, setSelectedRepo] = useState<string>(
-    getSetting<string>("selected-repo", ""),
+    getSetting("selected-repo"),
   );
   const exportId = useMemo(() => nanoid(), []);
   useEffect(() => {
@@ -171,7 +171,7 @@ const ExportDialog: ExportDialogComponent = ({
   }, [initialPanel]);
   const [includeDiscourseContext, setIncludeDiscourseContext] = useState(false);
   const [gitHubAccessToken, setGitHubAccessToken] = useState<string | null>(
-    getSetting<string | null>("oauth-github", null),
+    getSetting<string>("oauth-github"),
   );
 
   const [canSendToGitHub, setCanSendToGitHub] = useState(false);
@@ -185,8 +185,8 @@ const ExportDialog: ExportDialogComponent = ({
     content: string;
     setError: (error: string) => void;
   }): Promise<{ status: number }> => {
-    const gitHubAccessToken = localStorageGet("github-oauth");
-    const selectedRepo = localStorageGet("github-repo");
+    const gitHubAccessToken = getSetting("github-oauth");
+    const selectedRepo = getSetting("github-repo");
 
     const encoder = new TextEncoder();
     const uint8Array = encoder.encode(content);
@@ -233,8 +233,8 @@ const ExportDialog: ExportDialogComponent = ({
     setError: (error: string) => void;
     pageUid: string;
   }): Promise<{ status: number }> => {
-    const gitHubAccessToken = localStorageGet("github-oauth");
-    const selectedRepo = localStorageGet("github-repo");
+    const gitHubAccessToken = getSetting("github-oauth");
+    const selectedRepo = getSetting("github-repo");
     try {
       // https://docs.github.com/en/rest/issues/issues?apiVersion=2022-11-28#create-an-issue
       const response = await apiPost({
@@ -253,7 +253,7 @@ const ExportDialog: ExportDialogComponent = ({
       });
       if (response.status === 401) {
         setError("Authentication failed. Please log in again.");
-        localStorageSet("github-oauth", "");
+        setSetting("github-oauth", "");
         return { status: 401 };
       }
 
@@ -699,7 +699,7 @@ const ExportDialog: ExportDialogComponent = ({
                     if (activeExportDestination === "github") {
                       const { title, content } = files[0];
                       const githubDestination =
-                        localStorageGet("github-destination");
+                        getSetting("github-destination");
                       try {
                         let status;
                         if (githubDestination === "File") {

apps/roam/src/components/ExportGithub.tsx

@@ -12,7 +12,7 @@ import apiGet from "roamjs-components/util/apiGet";
 import apiPost from "roamjs-components/util/apiPost";
 import { getNodeEnv } from "roamjs-components/util/env";
 import getExtensionApi from "roamjs-components/util/extensionApiContext";
-import { setSetting } from "~/utils/extensionSettings";
+import { getSetting, setSetting } from "~/utils/extensionSettings";
 
 export type UserReposResponse = {
   data: [
@@ -45,7 +45,7 @@ export const fetchInstallationStatus = async () => {
       domain: "https://api.github.com",
       path: "user/installations",
       headers: {
-        Authorization: `token ${localStorageGet("github-oauth")}`,
+        Authorization: `token ${getSetting("github-oauth")}`,
       },
     });
     const installations = res.installations;
@@ -75,14 +75,12 @@ export const ExportGithub = ({
   const [repos, setRepos] = useState<UserRepos>(initialRepos);
   const [state, setState] = useState("");
   const [gitHubAccessToken, _setGitHubAccessToken] = useState<string>(
-    localStorageGet("github-oauth"),
+    getSetting("github-oauth"),
   );
   const [githubDestination, _setGithubDestination] =
-    useState<GitHubDestination>(
-      (localStorageGet("github-destination") as GitHubDestination) || "File",
-    );
-  const [selectedRepo, _setSelectedRepo] = useState(
-    localStorageGet("github-repo"),
+    useState<GitHubDestination>(getSetting("github-destination") || "File");
+  const [selectedRepo, _setSelectedRepo] = useState<string>(
+    getSetting("github-repo"),
   );
   const showGitHubLogin = isGitHubAppInstalled && !gitHubAccessToken;
   const repoAndDestinationSelectEnabled =

apps/roam/src/utils/extensionSettings.ts

@@ -1,16 +1,12 @@
 import getExtensionAPI from "roamjs-components/util/extensionApiContext";
 
-export function getSetting<T>(key: string, defaultValue?: T): T {
+export const getSetting = <T>(key: string, defaultValue: T = null as T): T => {
   const extensionAPI = getExtensionAPI();
-  const value = extensionAPI.settings.get(key);
+  const value = extensionAPI.settings.get(key) as T;
+  return value ?? defaultValue;
+};
 
-  if (value !== undefined && value !== null) {
-    return value as T;
-  }
-  return defaultValue as T;
-}
-
-export function setSetting<T>(key: string, value: T): void {
+export const setSetting = <T>(key: string, value: T): void => {
   const extensionAPI = getExtensionAPI();
   extensionAPI.settings.set(key, value);
-}
+};