ENG-1122 use or-join-clause so the variables are exposed to the optimizer (#584)

Author: maparent

apps/roam/src/utils/conditionToDatalog.ts

@@ -446,7 +446,7 @@ const translator: Record<string, Translator> = {
       if (currentUserMatch) {
         return [
           {
-            type: "or-clause",
+            type: "or-join-clause",
             clauses: [
               {
                 type: "data-pattern",
@@ -465,6 +465,7 @@ const translator: Record<string, Translator> = {
                 ],
               },
             ],
+            variables: [{ type: "variable", value: `${source}-String` }],
           },
           {
             type: "pred-expr",
@@ -481,7 +482,7 @@ const translator: Record<string, Translator> = {
         const rePattern = regexRePatternValue(target);
         return [
           {
-            type: "or-clause",
+            type: "or-join-clause",
             clauses: [
               {
                 type: "data-pattern",
@@ -500,6 +501,7 @@ const translator: Record<string, Translator> = {
                 ],
               },
             ],
+            variables: [{ type: "variable", value: `${source}-String` }],
           },
           {
             type: "fn-expr",
@@ -528,7 +530,7 @@ const translator: Record<string, Translator> = {
 
       return [
         {
-          type: "or-clause",
+          type: "or-join-clause",
           clauses: [
             {
               type: "data-pattern",
@@ -547,6 +549,7 @@ const translator: Record<string, Translator> = {
               ],
             },
           ],
+          variables: [{ type: "variable", value: `${source}-String` }],
         },
         {
           type: "pred-expr",