coderabbit nits

Author: maparent

packages/database/features/step-definitions/stepdefs.ts

@@ -412,8 +412,8 @@ When("user of space {word} creates group {word}", async (spaceName: string, name
     // eslint-disable-next-line @typescript-eslint/naming-convention
     const response = await client.functions.invoke<{group_id: string}>("create-group", {body:{name}});
     assert.equal(response.error, null);
-    assert.notStrictEqual(response.data, null);
-    localRefs[name] = response.data!.group_id;
+    assert.ok(response.data?.group_id, "create-group response missing group_id");
+    localRefs[name] = response.data.group_id;
   } catch (error) {
     console.error((error as Record<string, any>).actual);
     throw error;
@@ -423,21 +423,21 @@ When("user of space {word} creates group {word}", async (spaceName: string, name
 When("user of space {word} adds space {word} to group {word}",
     async (space1Name: string, space2Name:string, groupName: string)=>{
   const localRefs = (world.localRefs || {}) as Record<string, number|string>;
-  const space1Id = localRefs[space1Name] as number;
-  const space2Id = localRefs[space2Name] as number;
-  const groupId = localRefs[groupName] as string;
-  if (space1Id === undefined) assert.fail("space1Id");
-  if (space2Id === undefined) assert.fail("space2Id");
-  if (groupId === undefined) assert.fail("groupId");
-  const client2 = await getLoggedinDatabase(space2Id);
+  const space1Id = localRefs[space1Name];
+  const space2Id = localRefs[space2Name];
+  const groupId = localRefs[groupName];
+  if (space1Id === undefined) assert.fail("space1Id not found");
+  if (space2Id === undefined) assert.fail("space2Id not found");
+  if (groupId === undefined) assert.fail("groupId not found");
+  const client2 = await getLoggedinDatabase(space2Id as number);
   const r1 = await client2.from("PlatformAccount").select("dg_account").eq("account_local_id", spaceAnonUserEmail("Roam", space2Id)).maybeSingle();
   assert.equal(r1.error, null);
   const memberId = r1.data?.dg_account;
-  assert(!!memberId);
-  const client1 = await getLoggedinDatabase(space1Id);
+  assert.ok(memberId, "memberId not found for space2");
+  const client1 = await getLoggedinDatabase(space1Id as number);
   const r2 = await client1.from("group_membership").insert({
     /* eslint-disable @typescript-eslint/naming-convention */
-    group_id: groupId,
+    group_id: groupId as string,
     member_id: memberId
     /* eslint-enable @typescript-eslint/naming-convention */
   });