ENG-1266: Bug: Component not loading on any page (#681)

* findDiscourseNode accepts title as well

* Refactor findDiscourseNode to ensure uid is always a string and update related components to handle uid correctly. This improves type safety and prevents potential undefined errors.

* .

---------

Co-authored-by: Michael Gartner <[email protected]>

Author: sid597

apps/roam/src/components/canvas/Tldraw.tsx

@@ -479,7 +479,7 @@ const TldrawCanvas = ({ title }: { title: string }) => {
         ? { x: lastTime.x + w * 0.025, y: lastTime.y + h * 0.05 }
         : { x: x - DEFAULT_WIDTH / 2, y: y - DEFAULT_HEIGHT / 2 };
       const nodeType = findDiscourseNode({
-        uid: e.detail.uid,
+        uid: e.detail.uid || "",
         nodes: allNodes,
       });
       if (nodeType) {

apps/roam/src/utils/findDiscourseNode.ts

@@ -8,19 +8,18 @@ const findDiscourseNode = ({
   title,
   nodes = getDiscourseNodes(),
 }: {
-  uid?: string;
+  uid: string;
   title?: string;
   nodes?: DiscourseNode[];
 }): DiscourseNode | false => {
-  if (uid === undefined) return false;
   if (typeof discourseNodeTypeCache[uid] !== "undefined") {
     return discourseNodeTypeCache[uid];
   }
 
   const matchingNode =
     nodes.find((node) =>
       title === undefined
-        ? matchDiscourseNode({ ...node, uid: uid })
+        ? matchDiscourseNode({ ...node, uid })
         : matchDiscourseNode({ ...node, title }),
     ) || false;
   discourseNodeTypeCache[uid] = matchingNode;

apps/roam/src/utils/formatUtils.ts

@@ -136,7 +136,7 @@ export const getReferencedNodeInFormat = ({
 }) => {
   let format = providedFormat;
   if (!format) {
-    const discourseNode = findDiscourseNode({ uid });
+    const discourseNode = findDiscourseNode({ uid: uid || "" });
     if (discourseNode) format = discourseNode.format;
   }
   if (!format) return null;

apps/roam/src/utils/initializeObserversAndListeners.ts

@@ -95,11 +95,10 @@ export const initObservers = async ({
         text: "(BETA) Suggestive Mode Enabled",
       }).value;
 
-      const nodes = getDiscourseNodes();
-      const node = findDiscourseNode({ title, nodes });
+      const uid = getPageUidByPageTitle(title);
+      const node = findDiscourseNode({ uid, title });
       const isDiscourseNode = node && node.backedBy !== "default";
       if (isDiscourseNode) {
-        const uid = getPageUidByPageTitle(title);
         if (isSuggestiveModeEnabled) {
           renderPossibleDuplicates(h1, title, node);
         }