diff --git a/apps/roam/src/components/canvas/Tldraw.tsx b/apps/roam/src/components/canvas/Tldraw.tsx index 3185fe5b7..adfb1b416 100644 --- a/apps/roam/src/components/canvas/Tldraw.tsx +++ b/apps/roam/src/components/canvas/Tldraw.tsx @@ -479,7 +479,7 @@ const TldrawCanvas = ({ title }: { title: string }) => { ? { x: lastTime.x + w * 0.025, y: lastTime.y + h * 0.05 } : { x: x - DEFAULT_WIDTH / 2, y: y - DEFAULT_HEIGHT / 2 }; const nodeType = findDiscourseNode({ - uid: e.detail.uid, + uid: e.detail.uid || "", nodes: allNodes, }); if (nodeType) { diff --git a/apps/roam/src/utils/findDiscourseNode.ts b/apps/roam/src/utils/findDiscourseNode.ts index 88d134489..345d0b41d 100644 --- a/apps/roam/src/utils/findDiscourseNode.ts +++ b/apps/roam/src/utils/findDiscourseNode.ts @@ -8,11 +8,10 @@ const findDiscourseNode = ({ title, nodes = getDiscourseNodes(), }: { - uid?: string; + uid: string; title?: string; nodes?: DiscourseNode[]; }): DiscourseNode | false => { - if (uid === undefined) return false; if (typeof discourseNodeTypeCache[uid] !== "undefined") { return discourseNodeTypeCache[uid]; } @@ -20,7 +19,7 @@ const findDiscourseNode = ({ const matchingNode = nodes.find((node) => title === undefined - ? matchDiscourseNode({ ...node, uid: uid }) + ? matchDiscourseNode({ ...node, uid }) : matchDiscourseNode({ ...node, title }), ) || false; discourseNodeTypeCache[uid] = matchingNode; diff --git a/apps/roam/src/utils/formatUtils.ts b/apps/roam/src/utils/formatUtils.ts index e4ba25287..b075ced89 100644 --- a/apps/roam/src/utils/formatUtils.ts +++ b/apps/roam/src/utils/formatUtils.ts @@ -136,7 +136,7 @@ export const getReferencedNodeInFormat = ({ }) => { let format = providedFormat; if (!format) { - const discourseNode = findDiscourseNode({ uid }); + const discourseNode = findDiscourseNode({ uid: uid || "" }); if (discourseNode) format = discourseNode.format; } if (!format) return null; diff --git a/apps/roam/src/utils/initializeObserversAndListeners.ts b/apps/roam/src/utils/initializeObserversAndListeners.ts index ff8dc09bb..cdb8e4d00 100644 --- a/apps/roam/src/utils/initializeObserversAndListeners.ts +++ b/apps/roam/src/utils/initializeObserversAndListeners.ts @@ -95,11 +95,10 @@ export const initObservers = async ({ text: "(BETA) Suggestive Mode Enabled", }).value; - const nodes = getDiscourseNodes(); - const node = findDiscourseNode({ title, nodes }); + const uid = getPageUidByPageTitle(title); + const node = findDiscourseNode({ uid, title }); const isDiscourseNode = node && node.backedBy !== "default"; if (isDiscourseNode) { - const uid = getPageUidByPageTitle(title); if (isSuggestiveModeEnabled) { renderPossibleDuplicates(h1, title, node); }