feat!: use the guild data provided on interactions

This could in theory use an optimisation of caching the guild, but  as
we do not have a good way to clear the cache afterwards, this is the
best we can implement at this point in time.

Author: onerandomusername

changelog/1235.breaking.rst

@@ -0,0 +1 @@
+:attr:`Interaction.guild` is now a :class:`Guild` instance if the guild could not be found in cache.

disnake/guild.py

@@ -96,6 +96,7 @@
     from .app_commands import APIApplicationCommand
     from .asset import AssetBytes
     from .automod import AutoModTriggerMetadata
+    from .interactions import Interaction
     from .permissions import Permissions
     from .state import ConnectionState
     from .template import Template
@@ -111,6 +112,7 @@
         Guild as GuildPayload,
         GuildFeature,
         MFALevel,
+        PartialGuild as PartialGuildPayload,
     )
     from .types.integration import Integration as IntegrationPayload, IntegrationType
     from .types.role import CreateRole as CreateRolePayload
@@ -5211,6 +5213,33 @@ async def fetch_soundboard_sounds(self) -> List[GuildSoundboardSound]:
         ]
 
 
+class PartialInteractionGuild(Guild):
+    """Reimplementation of :class:`Guild` for guilds interactions."""
+
+    def __init__(
+        self,
+        *,
+        state: ConnectionState,
+        data: PartialGuildPayload,
+        interaction: Interaction,
+    ) -> None:
+        super().__init__(state=state, data=data)
+        # init the fake data
+        self._add_role(
+            Role(
+                state=state,
+                guild=self,
+                data={"id": self.id, "name": "@everyone"},  # type: ignore
+            )
+        )
+        self._add_channel(interaction.channel)  # type: ignore
+        # honestly we cannot set me, because we do not necessarily have a user in the guild
+
+    @property
+    def me(self) -> Any:
+        return self._state.user
+
+
 PlaceholderID = NewType("PlaceholderID", int)
 
 

disnake/interactions/base.py

@@ -43,7 +43,7 @@
     NotFound,
 )
 from ..flags import InteractionContextTypes, MessageFlags
-from ..guild import Guild
+from ..guild import Guild, PartialInteractionGuild
 from ..http import HTTPClient
 from ..i18n import Localized
 from ..member import Member
@@ -80,6 +80,7 @@
         Modal as ModalPayload,
         ModalTopLevelComponent as ModalTopLevelComponentPayload,
     )
+    from ..types.guild import PartialGuild as PartialGuildPayload
     from ..types.interactions import (
         ApplicationCommandOptionChoice as ApplicationCommandOptionChoicePayload,
         Interaction as InteractionPayload,
@@ -222,6 +223,7 @@ class Interaction(Generic[ClientT]):
         "_state",
         "_session",
         "_original_response",
+        "_guild",
         "_cs_response",
         "_cs_followup",
         "_cs_me",
@@ -242,6 +244,7 @@ def __init__(self, *, data: InteractionPayload, state: ConnectionState) -> None:
         self.version: int = data["version"]
         self.application_id: int = int(data["application_id"])
         self.guild_id: Optional[int] = utils._get_as_snowflake(data, "guild_id")
+        self._guild: Optional[PartialGuildPayload] = data.get("guild")
 
         self.locale: Locale = try_enum(Locale, data["locale"])
         guild_locale = data.get("guild_locale")
@@ -254,19 +257,15 @@ def __init__(self, *, data: InteractionPayload, state: ConnectionState) -> None:
         # one of user and member will always exist
         self.author: Union[User, Member] = MISSING
 
-        guild_fallback: Optional[Union[Guild, Object]] = None
-        if self.guild_id:
-            guild_fallback = self.guild or Object(self.guild_id)
+        guild_fallback: Optional[Guild] = None
 
-        if guild_fallback and (member := data.get("member")):
-            self.author = (
-                isinstance(guild_fallback, Guild)
-                and guild_fallback.get_member(int(member["user"]["id"]))
-            ) or Member(
+        if self.guild_id and (guild_fallback := self.guild) and (member := data.get("member")):
+            self.author = guild_fallback.get_member(int(member["user"]["id"])) or Member(
                 state=self._state,
-                guild=guild_fallback,  # type: ignore  # may be `Object`
+                guild=guild_fallback,
                 data=member,
             )
+
             self._permissions = int(member.get("permissions", 0))
         elif user := data.get("user"):
             self.author = self._state.store_user(user)
@@ -322,8 +321,29 @@ def guild(self) -> Optional[Guild]:
 
             To check whether an interaction was sent from a guild, consider using
             :attr:`guild_id` or :attr:`context` instead.
+
+        .. versionchanged:: 2.12
+            Returns a :class:`Guild` object when the guild could not be resolved from cache.
+            This object is created from the data provided by Discord, but it is not complete.
+            The only populated attributes are:
+                - :attr:`Guild.id`
+                - :attr:`Guild.preferred_locale`
+                - :attr:`Guild.features`
         """
-        return self._state._get_guild(self.guild_id)
+        if self.guild_id is None:
+            return None
+
+        guild = self._state._get_guild(self.guild_id)
+        if guild:
+            return guild
+        if self._guild is None:
+            return None
+
+        # create a guild mash
+        # honestly we should cache this for the duration of the interaction
+        # but not if we fetch it from the cache, just the result of this creation
+        guild = PartialInteractionGuild(data=self._guild, state=self._state, interaction=self)
+        return guild
 
     @utils.cached_slot_property("_cs_me")
     def me(self) -> Union[Member, ClientUser]:

disnake/types/guild.py

@@ -153,6 +153,10 @@ class Guild(_BaseGuildPreview):
     soundboard_sounds: NotRequired[List[GuildSoundboardSound]]
 
 
+class PartialGuild(Guild, total=False):
+    pass
+
+
 class InviteGuild(Guild, total=False):
     welcome_screen: WelcomeScreen
 

disnake/types/interactions.py

@@ -9,6 +9,7 @@
 from .components import MessageTopLevelComponent, Modal
 from .embed import Embed
 from .entitlement import Entitlement
+from .guild import PartialGuild
 from .i18n import LocalizationDict
 from .member import Member, MemberWithUser
 from .role import Role
@@ -326,6 +327,7 @@ class _BaseUserInteraction(_BaseInteraction):
     channel: InteractionChannel
     locale: str
     guild_id: NotRequired[Snowflake]
+    guild: NotRequired[PartialGuild]
     guild_locale: NotRequired[str]
     entitlements: NotRequired[List[Entitlement]]
     authorizing_integration_owners: NotRequired[AuthorizingIntegrationOwners]