fix(voice): send speaking packet on reconnect (#862)

`AudioPlayer` would previously not update the
[`SPEAKING`](https://discord.com/developers/docs/topics/voice-connections#speaking)
state to a non-zero value after reconnecting (which happens when moving
between channels, for instance). This results in the bot continuing to
send audio packets, which aren't processed by Discord as the speaking
state would still be `0`.

Author: shiftinv

changelog/845.bugfix.rst

@@ -0,0 +1 @@
+Fix :class:`VoiceClient` not continuing to play audio when moving between channels.

disnake/gateway.py

@@ -1067,7 +1067,7 @@ def average_latency(self) -> float:
     async def load_secret_key(self, data: VoiceSessionDescriptionPayload) -> None:
         _log.info("received secret key for voice connection")
         self.secret_key = self._connection.secret_key = data["secret_key"]
-        await self.speak()
+        # need to send this at least once to set the ssrc
         await self.speak(False)
 
     async def poll_event(self) -> None:

disnake/player.py

@@ -690,12 +690,10 @@ def __init__(self, source: AudioSource, client: VoiceClient, *, after=None) -> N
             raise TypeError('Expected a callable for the "after" parameter.')
 
     def _do_run(self) -> None:
-        self.loops = 0
-        self._start = time.perf_counter()
+        self._reset_state(speak=True)
 
         # getattr lookup speed ups
         play_audio = self.client.send_audio_packet
-        self._speak(True)
 
         while not self._end.is_set():
             # are we paused?
@@ -709,8 +707,7 @@ def _do_run(self) -> None:
                 # wait until we are connected
                 self._connected.wait()
                 # reset our internal data
-                self.loops = 0
-                self._start = time.perf_counter()
+                self._reset_state(speak=self._resumed.is_set())
 
             self.loops += 1
             data = self.source.read()
@@ -724,6 +721,14 @@ def _do_run(self) -> None:
             delay = max(0, self.DELAY + (next_time - time.perf_counter()))
             time.sleep(delay)
 
+    # this is called right after (re)connecting;
+    # reset the timings and set the speaking state accordingly
+    def _reset_state(self, *, speak: bool) -> None:
+        self.loops = 0
+        self._start = time.perf_counter()
+        if speak:
+            self._speak(True)
+
     def run(self) -> None:
         try:
             self._do_run()