Skip to content

Commit 42efd5e

Browse files
committed
refactor: move nanobind imports to common header
1 parent f176e47 commit 42efd5e

File tree

9 files changed

+26
-39
lines changed

9 files changed

+26
-39
lines changed

src/binding_core.hpp

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
#pragma once
2+
3+
#include <nanobind/nanobind.h>
4+
#include <nanobind/stl/chrono.h>
5+
#include <nanobind/stl/function.h>
6+
#include <nanobind/stl/map.h>
7+
#include <nanobind/stl/optional.h>
8+
#include <nanobind/stl/set.h>
9+
#include <nanobind/stl/shared_ptr.h>
10+
#include <nanobind/stl/string.h>
11+
#include <nanobind/stl/unique_ptr.h>
12+
#include <nanobind/stl/variant.h>
13+
#include <nanobind/stl/vector.h>
14+
15+
namespace nb = nanobind;
16+
17+
namespace dave = discord::dave;

src/dave.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
11
#include <dave/common.h>
2-
#include <nanobind/nanobind.h>
32

3+
#include "binding_core.hpp"
44
#include "logging.hpp"
55

6-
namespace nb = nanobind;
7-
namespace dave = discord::dave;
8-
96
// since these are all (mostly) self-contained bindings,
107
// just forward-declare these functions instead of writing headers for everything
118
void bindDecryptor(nb::module_& m);

src/decryptor.cpp

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
11
#include <dave/decryptor.h>
22
#include <dave/logger.h>
3-
#include <nanobind/nanobind.h>
4-
#include <nanobind/stl/chrono.h>
5-
#include <nanobind/stl/optional.h>
6-
#include <nanobind/stl/unique_ptr.h>
73

8-
namespace nb = nanobind;
9-
namespace dave = discord::dave;
4+
#include "binding_core.hpp"
105

116
class DecryptorWrapper {
127
private:

src/encryptor.cpp

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
11
#include <dave/encryptor.h>
22
#include <dave/logger.h>
3-
#include <nanobind/nanobind.h>
4-
#include <nanobind/stl/function.h>
5-
#include <nanobind/stl/optional.h>
6-
#include <nanobind/stl/unique_ptr.h>
73

8-
namespace nb = nanobind;
9-
namespace dave = discord::dave;
4+
#include "binding_core.hpp"
105

116
class EncryptorWrapper {
127
private:

src/logging.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
#pragma once
22

33
#include <dave/logger.h>
4-
#include <nanobind/nanobind.h>
5-
#include <nanobind/stl/string.h>
4+
5+
#include "binding_core.hpp"
66

77
namespace nb = nanobind;
88

src/session.cpp

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,9 @@
11
#include <dave/mls/session.h>
2-
#include <nanobind/nanobind.h>
3-
#include <nanobind/stl/function.h>
4-
#include <nanobind/stl/map.h>
5-
#include <nanobind/stl/optional.h>
6-
#include <nanobind/stl/set.h>
7-
#include <nanobind/stl/shared_ptr.h>
8-
#include <nanobind/stl/string.h>
9-
#include <nanobind/stl/unique_ptr.h>
10-
#include <nanobind/stl/variant.h>
11-
#include <nanobind/stl/vector.h>
122

3+
#include "binding_core.hpp"
134
#include "signature_key_pair.hpp"
145
#include "utils.hpp"
156

16-
namespace nb = nanobind;
17-
namespace dave = discord::dave;
18-
197
// used instead of std::variant for hard-/soft-rejecting messages
208
enum RejectType : uint8_t {
219
Failed, // dave::failed_t

src/signature_key_pair.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
#include "signature_key_pair.hpp"
22

33
#include <dave/mls/parameters.h>
4-
#include <nanobind/stl/string.h>
54

6-
namespace nb = nanobind;
7-
namespace dave = discord::dave;
5+
#include "binding_core.hpp"
86

97
SignatureKeyPair SignatureKeyPair::generate(dave::ProtocolVersion version) {
108
auto suite = dave::mls::CiphersuiteForProtocolVersion(version);

src/signature_key_pair.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
#pragma once
22

33
#include <dave/mls/parameters.h>
4-
#include <nanobind/nanobind.h>
54

6-
namespace dave = discord::dave;
5+
#include "binding_core.hpp"
76

87
class SignatureKeyPair {
98
private:

src/utils.hpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
#pragma once
22

3-
#include <nanobind/nanobind.h>
4-
53
#include <vector>
64

7-
namespace nb = nanobind;
5+
#include "binding_core.hpp"
86

97
namespace nanobind {
108

0 commit comments

Comments
 (0)