Merge branch 'master' of https://github.com/ropensci/plotly

Author: chschan

NEWS.md

@@ -44,14 +44,18 @@ This is minor patch release with a few minor bug fixes and updates test expectat
 
 ## IMPROVEMENTS
 
-* All HTTP requests are now retried upon failure (#1656)
+* All HTTP requests are now retried upon failure (#1656, @jameslamb).
+
+* R linebreaks (`\n`) in _factor labels_ are now translated to HTML linebreaks (`<br />`), too. Before, this conversion was only done for colums of type character. ([#1700](https://github.com/ropensci/plotly/pull/1700), @salim-b).
 
 * R linebreaks (`\n`) in _factor labels_ are now translated to HTML linebreaks (`<br />`), too. Before, this conversion was only done for colums of type character. ([#1700](https://github.com/ropensci/plotly/pull/1700), @salim-b)
 
 ## BUG FIXES
 
 * `ggplotly()` now handles discrete axes of a `facet_wrap` and `facet_grid` correctly when there is only one category in panels > 1 (#1577 and #1720).
 
+* `ggplotly()` now correctly accounts for linebreaks in tick label text when computing plot margins (#1791, @trekonom).
+
 * `ggplotly()` now handles `element_blank()` and `factor()` labels in positional scales correctly (#1731 and #1772).
 
 # 4.9.2.1

R/ggplotly.R

@@ -806,7 +806,9 @@ gg2list <- function(p, width = NULL, height = NULL,
 
       # do some stuff that should be done once for the entire plot
       if (i == 1) {
-        axisTickText <- longest_element(axisObj$ticktext)
+        # Split ticktext elements by "\n"  to account for linebreaks
+        axisTickText <- strsplit(as.character(axisObj$ticktext), split = "\n", fixed = TRUE)
+        axisTickText <- longest_element(unlist(axisTickText))
         side <- if (xy == "x") "b" else "l"
         # account for axis ticks, ticks text, and titles in plot margins
         # (apparently ggplot2 doesn't support axis.title/axis.text margins)