don't supply axis domain defaults if layout.grid is specified, fixes plotly#1427

cpsievert · cpsievert · commit fbcf3919f71d · 2019-03-07T18:12:33.000-06:00
diff --git a/R/utils.R b/R/utils.R
@@ -348,7 +348,7 @@ supply_defaults <- function(p) {
     p$x$layout[[p$x$layout$mapType]] <- modify_list(
       list(domain = geoDomain), p$x$layout[[p$x$layout$mapType]]
     )
-  } else {
+  } else if (!length(p$x$layout[["grid"]])) {
     types <- vapply(p$x$data, function(tr) tr[["type"]] %||% "scatter", character(1))
     axes <- unlist(lapply(types, function(x) {
       grep("^[a-z]axis$", names(Schema$traces[[x]]$attributes), value = TRUE) %||% NULL

Original file line number	Diff line number	Diff line change
`@@ -348,7 +348,7 @@ supply_defaults <- function(p) {`
`348`	`348`	`p$x$layout[[p$x$layout$mapType]] <- modify_list(`
`349`	`349`	`list(domain = geoDomain), p$x$layout[[p$x$layout$mapType]]`
`350`	`350`	`)`
`351`		`- } else {`
	`351`	`+ } else if (!length(p$x$layout[["grid"]])) {`
`352`	`352`	`types <- vapply(p$x$data, function(tr) tr[["type"]] %\|\|% "scatter", character(1))`
`353`	`353`	`axes <- unlist(lapply(types, function(x) {`
`354`	`354`	`grep("^[a-z]axis$", names(Schema$traces[[x]]$attributes), value = TRUE) %\|\|% NULL`