Skip to content

Commit 2d2dcbf

Browse files
simplify exception logic
1 parent face6db commit 2d2dcbf

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

src/JSObjectProxy.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -321,10 +321,6 @@ PyObject *JSObjectProxyMethodDefinitions::JSObjectProxy_iter_next(JSObjectProxy
321321
PyObject *retVal = JSFunctionProxyMethodDefinitions::JSFunctionProxy_call(nextFunction, PyTuple_New(0), NULL);
322322
Py_DECREF(nextFunction);
323323
if (retVal == NULL) {
324-
if (PyErr_Occurred()) {
325-
PyErr_PrintEx(0);
326-
}
327-
PyErr_SetNone(PyExc_StopIteration);
328324
return NULL;
329325
}
330326

tests/python/test_dict_methods.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -569,5 +569,6 @@ def test_next_operator_non_iterator():
569569
try:
570570
next(make_js_generator(range(0,5)))
571571
assert (False)
572-
except StopIteration as e:
573-
assert (True)
572+
except Exception as e:
573+
assert str(type(e)) == "<class 'pythonmonkey.SpiderMonkeyError'>"
574+
assert str(e).__contains__("'range' object is not an iterator")

0 commit comments

Comments
 (0)