fix(XHR): do nothing instead of throwing a DOMException when setting xhr.withCredentials

Xmader · Xmader · commit 320462fe5256 · 2024-02-02T15:55:16.000Z
Socket.IO would die in the middle between `xhr.open` and `xhr.send`
diff --git a/python/pythonmonkey/builtin_modules/XMLHttpRequest.js b/python/pythonmonkey/builtin_modules/XMLHttpRequest.js
@@ -182,7 +182,7 @@ class XMLHttpRequest extends XMLHttpRequestEventTarget
   }
   set withCredentials(flag)
   {
-    throw new DOMException('xhr.withCredentials is not supported in PythonMonkey.', 'InvalidAccessError');
+    // do nothing
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ class XMLHttpRequest extends XMLHttpRequestEventTarget`
`182`	`182`	`}`
`183`	`183`	`set withCredentials(flag)`
`184`	`184`	`{`
`185`		`- throw new DOMException('xhr.withCredentials is not supported in PythonMonkey.', 'InvalidAccessError');`
	`185`	`+ // do nothing`
`186`	`186`	`}`
`187`	`187`
`188`	`188`	`/**`