added toString support

Author: philippedistributive

src/PyBytesProxyHandler.cc

@@ -50,7 +50,12 @@ static bool bytes_valueOf(JSContext *cx, unsigned argc, JS::Value *vp) {
   return true;
 }
 
+static bool bytes_toString(JSContext *cx, unsigned argc, JS::Value *vp) {
+  return bytes_valueOf(cx, argc, vp);
+}
+
 JSMethodDef PyBytesProxyHandler::bytes_methods[] = {
+  {"toString", bytes_toString, 0},
   {"valueOf", bytes_valueOf, 0},
   {NULL, NULL, 0}
 };

src/PyObjectProxyHandler.cc

@@ -72,6 +72,7 @@ bool PyObjectProxyHandler::handleOwnPropertyKeys(JSContext *cx, PyObject *keys,
   return true;
 }
 
+// TODO need to let subclasses call superclass methods
 bool PyObjectProxyHandler::handleGetOwnPropertyDescriptor(JSContext *cx, JS::HandleId id,
   JS::MutableHandle<mozilla::Maybe<JS::PropertyDescriptor>> desc, PyObject *item) {
   // see if we're calling a function

tests/python/test_buffer_typed_array.py

@@ -246,10 +246,20 @@ def test_bytes_byteoffset():
 
 def test_bytes_instanceof():
   result = [None]
-  pm.eval("(result, obj) => {result[0] = obj instanceof Uint8Array}")(result, bytes("hello world", "ascii"))
+  pm.eval("(result, bytes) => {result[0] = bytes instanceof Uint8Array}")(result, bytes("hello world", "ascii"))
   assert result[0]
 
 
+def test_bytes_valueOf():
+  a = pm.eval('(bytes) => bytes.valueOf()')(bytes("hello world", "ascii"))
+  assert a == "h,e,l,l,o, ,w,o,r,l,d"   
+
+
+def test_bytes_toString():
+  a = pm.eval('(bytes) => bytes.toString()')(bytes("hello world", "ascii"))
+  assert a == "h,e,l,l,o, ,w,o,r,l,d"    
+
+
 def test_bytes_console():
   temp_out = StringIO()
   sys.stdout = temp_out