fix(event-loop): the Debugger API requires JobQueue::runJobs and JobQueue::saveJobQueue to be implemented

Xmader · Xmader · commit 3a95495f696b · 2023-07-25T08:02:04.000Z
diff --git a/src/JobQueue.cc b/src/JobQueue.cc
@@ -39,8 +39,7 @@ bool JobQueue::enqueuePromiseJob(JSContext *cx,
 }
 
 void JobQueue::runJobs(JSContext *cx) {
-  // TODO (Tom Tang):
-  throw std::logic_error("JobQueue::runJobs is not implemented.");
+  return;
 }
 
 // is empty
@@ -50,8 +49,8 @@ bool JobQueue::empty() const {
 }
 
 js::UniquePtr<JS::JobQueue::SavedJobQueue> JobQueue::saveJobQueue(JSContext *cx) {
-  // TODO (Tom Tang): implement this method way later
-  throw std::logic_error("JobQueue::saveJobQueue is not implemented\n");
+  auto saved = js::MakeUnique<JS::JobQueue::SavedJobQueue>();
+  return saved;
 }
 
 bool JobQueue::init(JSContext *cx) {

Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,7 @@ bool JobQueue::enqueuePromiseJob(JSContext *cx,`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`void JobQueue::runJobs(JSContext *cx) {`
`42`		`- // TODO (Tom Tang):`
`43`		`- throw std::logic_error("JobQueue::runJobs is not implemented.");`
	`42`	`+ return;`
`44`	`43`	`}`
`45`	`44`
`46`	`45`	`// is empty`
`@@ -50,8 +49,8 @@ bool JobQueue::empty() const {`
`50`	`49`	`}`
`51`	`50`
`52`	`51`	`js::UniquePtr<JS::JobQueue::SavedJobQueue> JobQueue::saveJobQueue(JSContext *cx) {`
`53`		`- // TODO (Tom Tang): implement this method way later`
`54`		`- throw std::logic_error("JobQueue::saveJobQueue is not implemented\n");`
	`52`	`+ auto saved = js::MakeUnique<JS::JobQueue::SavedJobQueue>();`
	`53`	`+ return saved;`
`55`	`54`	`}`
`56`	`55`
`57`	`56`	`bool JobQueue::init(JSContext *cx) {`