further cleanup

Author: philippedistributive

include/JSObjectIterProxy.hh

@@ -29,7 +29,7 @@
 
 typedef struct {
   PyObject_HEAD
-  JS::RootedIdVector *props;
+  JS::RootedIdVector *props; // not conceptually the best use of the Rooted type but it works. There is no easy inter-operation with a JS::Heap type
   int it_index;
   bool reversed;
   int kind;

python/pythonmonkey/require.py

@@ -1,7 +1,7 @@
 # @file         require.py
 #               Implementation of CommonJS "require" for PythonMonkey. This implementation uses the
 #               ctx-module npm package to do the heavy lifting. That package makes a complete module
-#               system, obstensibly in a separate context, but our implementation here reuses the
+#               system, ostensibly in a separate context, but our implementation here reuses the
 #               PythonMonkey global context for both.
 #
 #               The context that ctx-module runs in needs a require function supporting
@@ -115,7 +115,7 @@
 
 /**
  * The debug module has as its exports a function which may, depending on the DEBUG env var, emit
- * debugging statemnts to stdout. This is quick implementation of the node built-in.
+ * debugging statements to stdout. This is quick implementation of the node built-in.
  */
 bootstrap.modules.debug = function debug(selector)
 {

src/modules/pythonmonkey/pythonmonkey.cc

@@ -1,11 +1,10 @@
 /**
  * @file pythonmonkey.cc
- * @author Caleb Aikens ([email protected])
+ * @author Caleb Aikens ([email protected]) and Philippe Laporte ([email protected])
  * @brief This file defines the pythonmonkey module, along with its various functions.
- * @version 0.1
  * @date 2023-03-29
  *
- * @copyright Copyright (c) 2023 Distributive Corp.
+ * @copyright Copyright (c) 2023-2024 Distributive Corp.
  *
  */
 
@@ -68,7 +67,7 @@ static PyTypeObject NullType = {
 static PyTypeObject BigIntType = {
   .tp_name = "pythonmonkey.bigint",
   .tp_flags = Py_TPFLAGS_DEFAULT
-  | Py_TPFLAGS_LONG_SUBCLASS // https://docs.python.org/3/c-api/typeobj.html#Py_TPFLAGS_LONG_SUBCLASS
+  | Py_TPFLAGS_LONG_SUBCLASS
   | Py_TPFLAGS_BASETYPE,     // can be subclassed
   .tp_doc = PyDoc_STR("Javascript BigInt object"),
   .tp_base = &PyLong_Type,   // extending the builtin int type
@@ -88,7 +87,7 @@ PyTypeObject JSObjectProxyType = {
   .tp_getattro = (getattrofunc)JSObjectProxyMethodDefinitions::JSObjectProxy_get,
   .tp_setattro = (setattrofunc)JSObjectProxyMethodDefinitions::JSObjectProxy_assign,
   .tp_flags = Py_TPFLAGS_DEFAULT
-  | Py_TPFLAGS_DICT_SUBCLASS,  // https://docs.python.org/3/c-api/typeobj.html#Py_TPFLAGS_DICT_SUBCLASS
+  | Py_TPFLAGS_DICT_SUBCLASS,
   .tp_doc = PyDoc_STR("Javascript Object proxy dict"),
   .tp_richcompare = (richcmpfunc)JSObjectProxyMethodDefinitions::JSObjectProxy_richcompare,
   .tp_iter = (getiterfunc)JSObjectProxyMethodDefinitions::JSObjectProxy_iter,
@@ -108,7 +107,7 @@ PyTypeObject JSArrayProxyType = {
   .tp_as_sequence = &JSArrayProxy_sequence_methods,
   .tp_as_mapping = &JSArrayProxy_mapping_methods,
   .tp_getattro = (getattrofunc)JSArrayProxyMethodDefinitions::JSArrayProxy_get,
-  .tp_flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_DICT_SUBCLASS,
+  .tp_flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_LIST_SUBCLASS,
   .tp_doc = PyDoc_STR("Javascript Array proxy list"),
   .tp_traverse = (traverseproc)JSArrayProxyMethodDefinitions::JSArrayProxy_traverse,
   .tp_clear = (inquiry)JSArrayProxyMethodDefinitions::JSArrayProxy_clear_slot,