Update src/PyListProxyHandler.cc

philippedistributive · zollqir · web-flow · commit 3c1ced23ec61 · 2024-04-22T12:30:14.000-04:00
Co-authored-by: Caleb Aikens &lt;caleb@distributive.network&gt;
diff --git a/src/PyListProxyHandler.cc b/src/PyListProxyHandler.cc
@@ -362,9 +362,12 @@ static bool array_splice(JSContext *cx, unsigned argc, JS::Value *vp) {
   JS::RootedValue elementVal(cx);
   for (int index = 0; index < insertCount; index++) {
     elementVal.set(args[index + 2].get());
-    if (PyList_SetItem(inserted, index, pyTypeFactory(cx, elementVal)) < 0) {
+    PyObject *value = pyTypeFactory(cx, elementVal);
+    if (PyList_SetItem(inserted, index, value) < 0) {
+      Py_DECREF(value);
       return false;
     }
+    Py_DECREF(value);
   }
 
   if (PyList_SetSlice(self, actualStart, actualStart + actualDeleteCount, inserted) < 0) {

Original file line number	Diff line number	Diff line change
`@@ -362,9 +362,12 @@ static bool array_splice(JSContext cx, unsigned argc, JS::Value vp) {`
`362`	`362`	`JS::RootedValue elementVal(cx);`
`363`	`363`	`for (int index = 0; index < insertCount; index++) {`
`364`	`364`	`elementVal.set(args[index + 2].get());`
`365`		`- if (PyList_SetItem(inserted, index, pyTypeFactory(cx, elementVal)) < 0) {`
	`365`	`+ PyObject *value = pyTypeFactory(cx, elementVal);`
	`366`	`+ if (PyList_SetItem(inserted, index, value) < 0) {`
	`367`	`+ Py_DECREF(value);`
`366`	`368`	`return false;`
`367`	`369`	`}`
	`370`	`+ Py_DECREF(value);`
`368`	`371`	`}`
`369`	`372`
`370`	`373`	`if (PyList_SetSlice(self, actualStart, actualStart + actualDeleteCount, inserted) < 0) {`