Update src/PyListProxyHandler.cc

philippedistributive · zollqir · web-flow · commit 525f530369fc · 2024-04-22T12:27:20.000-04:00
Co-authored-by: Caleb Aikens &lt;caleb@distributive.network&gt;
diff --git a/src/PyListProxyHandler.cc b/src/PyListProxyHandler.cc
@@ -112,9 +112,12 @@ static bool array_push(JSContext *cx, unsigned argc, JS::Value *vp) { // surely
   JS::RootedValue elementVal(cx);
   for (unsigned index = 0; index < numArgs; index++) {
     elementVal.set(args[index].get());
-    if (PyList_Append(self, pyTypeFactory(cx, elementVal)) < 0) {
+    PyObject *value = pyTypeFactory(cx, elementVal);
+    if (PyList_Append(self, value) < 0) {
+      Py_DECREF(value);
       return false;
     }
+    Py_DECREF(value);
   }
 
   args.rval().setInt32(PyList_GET_SIZE(self));

Original file line number	Diff line number	Diff line change
`@@ -112,9 +112,12 @@ static bool array_push(JSContext cx, unsigned argc, JS::Value vp) { // surely`
`112`	`112`	`JS::RootedValue elementVal(cx);`
`113`	`113`	`for (unsigned index = 0; index < numArgs; index++) {`
`114`	`114`	`elementVal.set(args[index].get());`
`115`		`- if (PyList_Append(self, pyTypeFactory(cx, elementVal)) < 0) {`
	`115`	`+ PyObject *value = pyTypeFactory(cx, elementVal);`
	`116`	`+ if (PyList_Append(self, value) < 0) {`
	`117`	`+ Py_DECREF(value);`
`116`	`118`	`return false;`
`117`	`119`	`}`
	`120`	`+ Py_DECREF(value);`
`118`	`121`	`}`
`119`	`122`
`120`	`123`	`args.rval().setInt32(PyList_GET_SIZE(self));`