refactor: move URL/URLSearchParams APIs into the url builtin_modules

Author: Xmader

python/pythonmonkey/__init__.py

@@ -13,10 +13,7 @@
 require("console")
 require("base64")
 require("timers")
-## npm packages
-require("core-js/actual/dom-exception")
-require("core-js/actual/url")
-require("core-js/actual/url-search-params")
+require("url")
 
 # Add the `.keys()` method on `Object.prototype` to get JSObjectProxy dict() conversion working
 # Conversion from a dict-subclass to a strict dict by `dict(subclass)` internally calls the .keys() method to read the dictionary keys, 

python/pythonmonkey/builtin_modules/url.d.ts

@@ -0,0 +1,111 @@
+/**
+ * @file     url.d.ts
+ *           Type definitions for URL/URLSearchParams
+ *
+ * @author   Tom Tang <[email protected]>
+ * @date     August 2023
+ */
+
+/*!
+ * Modified from https://www.npmjs.com/package/@types/web
+ * Apache License 2.0
+ */
+
+/**
+ * The URL interface represents an object providing static methods used for creating object URLs.
+ *
+ * [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL)
+ */
+export interface URL {
+  /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/hash) */
+  hash: string;
+  /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/host) */
+  host: string;
+  /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/hostname) */
+  hostname: string;
+  /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/href) */
+  href: string;
+  toString(): string;
+  /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/origin) */
+  readonly origin: string;
+  /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/password) */
+  password: string;
+  /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/pathname) */
+  pathname: string;
+  /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/port) */
+  port: string;
+  /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/protocol) */
+  protocol: string;
+  /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/search) */
+  search: string;
+  /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/searchParams) */
+  readonly searchParams: URLSearchParams;
+  /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/username) */
+  username: string;
+  /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/toJSON) */
+  toJSON(): string;
+}
+
+export declare var URL: {
+  prototype: URL;
+  new(url: string | URL, base?: string | URL): URL;
+  /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/canParse_static) */
+  canParse(url: string | URL, base?: string): boolean;
+  /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/createObjectURL_static) @deprecated not implemented by polyfill */
+  // @ts-expect-error types not defined
+  createObjectURL(obj: Blob | MediaSource): string;
+  /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL/revokeObjectURL_static) @deprecated not implemented by polyfill */
+  revokeObjectURL(url: string): void;
+};
+
+/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/URLSearchParams) */
+export interface URLSearchParams {
+  /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/URLSearchParams/size) */
+  readonly size: number;
+  /**
+   * Appends a specified key/value pair as a new search parameter.
+   *
+   * [MDN Reference](https://developer.mozilla.org/docs/Web/API/URLSearchParams/append)
+   */
+  append(name: string, value: string): void;
+  /**
+   * Deletes the given search parameter, and its associated value, from the list of all search parameters.
+   *
+   * [MDN Reference](https://developer.mozilla.org/docs/Web/API/URLSearchParams/delete)
+   */
+  delete(name: string, value?: string): void;
+  /**
+   * Returns the first value associated to the given search parameter.
+   *
+   * [MDN Reference](https://developer.mozilla.org/docs/Web/API/URLSearchParams/get)
+   */
+  get(name: string): string | null;
+  /**
+   * Returns all the values association with a given search parameter.
+   *
+   * [MDN Reference](https://developer.mozilla.org/docs/Web/API/URLSearchParams/getAll)
+   */
+  getAll(name: string): string[];
+  /**
+   * Returns a Boolean indicating if such a search parameter exists.
+   *
+   * [MDN Reference](https://developer.mozilla.org/docs/Web/API/URLSearchParams/has)
+   */
+  has(name: string, value?: string): boolean;
+  /**
+   * Sets the value associated to a given search parameter to the given value. If there were several values, delete the others.
+   *
+   * [MDN Reference](https://developer.mozilla.org/docs/Web/API/URLSearchParams/set)
+   */
+  set(name: string, value: string): void;
+  /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/URLSearchParams/sort) */
+  sort(): void;
+  /** Returns a string containing a query string suitable for use in a URL. Does not include the question mark. */
+  toString(): string;
+  forEach(callbackfn: (value: string, key: string, parent: URLSearchParams) => void, thisArg?: any): void;
+}
+
+export declare var URLSearchParams: {
+  prototype: URLSearchParams;
+  new(init?: string[][] | Record<string, string> | string | URLSearchParams): URLSearchParams;
+};

python/pythonmonkey/builtin_modules/url.js

@@ -0,0 +1,15 @@
+/**
+ * @file     url.js
+ *           Polyfill the URL and URLSearchParams interfaces 
+ *
+ * @author   Tom Tang <[email protected]>
+ * @date     August 2023
+ */
+
+// Apply polyfills from core-js
+require("core-js/actual/dom-exception")
+require("core-js/actual/url")
+require("core-js/actual/url-search-params")
+
+exports.URL = globalThis.URL;
+exports.URLSearchParams = globalThis.URLSearchParams;

python/pythonmonkey/global.d.ts

@@ -55,6 +55,10 @@ declare var btoa: typeof import("base64").btoa;
 declare var setTimeout: typeof import("timers").setTimeout;
 declare var clearTimeout: typeof import("timers").clearTimeout;
 
+// Expose `URL`/`URLSearchParams` APIs
+declare var URL: typeof import("url").URL;
+declare var URLSearchParams: typeof import("url").URLSearchParams;
+
 // Keep this in sync with both https://hg.mozilla.org/releases/mozilla-esr102/file/a03fde6/js/public/Promise.h#l331
 //                        and  https://github.com/nodejs/node/blob/v20.2.0/deps/v8/include/v8-promise.h#L30
 declare enum PromiseState { Pending = 0, Fulfilled = 1, Rejected = 2 }