Skip to content

Commit 65e852f

Browse files
committed
fix: class prototypes cannot be properly set
test_bytes_instanceof: Python bytes instanceof JS Uint8Array assert False test_keys_iterator: TypeError iterator is not iterable If `explicit-resource-management` is enabled, the lib .so will be compiled differently to the header files when there's a `IF_EXPLICIT_RESOURCE_MANAGEMENT` macro used. The `enum JSProtoKey` index is off by 1 (header `JSProto_Uint8Array` 27 will be interpreted as `JSProto_Int8Array` in lib as lib has an extra element)
1 parent 9864c51 commit 65e852f

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

setup.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,10 @@ mkdir -p ../../../../_spidermonkey_install/
7979
--disable-jemalloc \
8080
--disable-tests \
8181
$(if [[ "$OSTYPE" == "darwin"* ]]; then echo "--enable-linker=ld64"; fi) \
82-
--enable-optimize
82+
--enable-optimize \
83+
--disable-explicit-resource-management
84+
# disable-explicit-resource-management: Disable the `using` syntax that is enabled by default in SpiderMonkey nightly, otherwise the header files will disagree with the compiled lib .so file
85+
# when it's using a `IF_EXPLICIT_RESOURCE_MANAGEMENT` macro, e.g., the `enum JSProtoKey` index would be off by 1 (header `JSProto_Uint8Array` 27 will be interpreted as `JSProto_Int8Array` in lib as lib has an extra element)
8386
make -j$CPUS
8487
echo "Done building spidermonkey"
8588

0 commit comments

Comments
 (0)