Need to get PyObject 's attribute which is not necessarily a dict

Author: philippedistributive

src/PyIterableProxyHandler.cc

@@ -294,7 +294,7 @@ bool PyIterableProxyHandler::getOwnPropertyDescriptor(
 
   PyObject *attrName = idToKey(cx, id);
   PyObject *self = JS::GetMaybePtrFromReservedSlot<PyObject>(proxy, PyObjectSlot);
-  PyObject *item = PyDict_GetItemWithError(self, attrName);
+  PyObject *item = PyObject_GetAttr(self, attrName);
 
   return handleGetOwnPropertyDescriptor(cx, id, desc, item);
 }

tests/python/test_objects.py

@@ -1,5 +1,6 @@
 import pythonmonkey as pm
 import sys
+from io import StringIO
 
 
 def test_eval_pyobjects():
@@ -170,4 +171,14 @@ def test_toPrimitive_stdin():
 
 def test_constructor_stdin():
   constructor = pm.eval("(obj) => { return obj.constructor; }")(sys.stdin)
-  assert repr(constructor).__contains__("<pythonmonkey.JSFunctionProxy object at")      
+  assert repr(constructor).__contains__("<pythonmonkey.JSFunctionProxy object at")      
+
+
+def test_stdin_tty_console_printing():
+  temp_out = StringIO()
+  sys.stdout = temp_out
+  obj = {}
+  obj['stdin'] = sys.stdin
+  obj['stdin'].isTTY = sys.stdin.isatty()
+  pm.eval('''(function iife(obj){console.log(obj['stdin'].isTTY);})''')(obj)
+  assert temp_out.getvalue() == "\x1b[33mfalse\x1b[39m\n"