Merge pull request #204 from Distributive-Network/philippe/fix/176-plus

Philippe/fix/176 plus

Author: philippedistributive

LICENSE

@@ -72,4 +72,51 @@ products or services of Licensee, or any third party.
 
 8. By copying, installing or otherwise using Python, Licensee
 agrees to be bound by the terms and conditions of this License
-Agreement.
+Agreement.
+
+-------------------------------------------------------------------------------
+
+Copyright Node.js contributors. All rights reserved.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to
+deal in the Software without restriction, including without limitation the
+rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+sell copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+IN THE SOFTWARE.
+"""
+
+This license applies to parts of Node.js originating from the
+https://github.com/joyent/node repository:
+
+"""
+Copyright Joyent, Inc. and other Node contributors. All rights reserved.
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to
+deal in the Software without restriction, including without limitation the
+rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
+sell copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+IN THE SOFTWARE.
+"""

README.md

@@ -55,7 +55,8 @@ js_eval("console.log")('hello, world')
 - Python host environment supplies basic subsets of NodeJS's fs, path, process, etc, modules; as-needed by dcp-client (other project?)
 - [done] Python TypedArrays coerce to JS TypeArrays
 - [done] JS TypedArrays coerce to Python TypeArrays
-- [done] Python List coerce to JS Arrays
+- [done] JS Arrays coerce to Python Lists, providing all List methods implemented on Arrays
+- [done] Python List coerce to JS Arrays, providing all Array methods implemented on Lists
 
 ## Build Instructions
 

include/JSArrayProxy.hh

@@ -24,7 +24,7 @@
  */
 typedef struct {
   PyListObject list;
-  JS::RootedObject jsObject;
+  JS::RootedObject jsArray;
 } JSArrayProxy;
 
 /**

include/PyProxyHandler.hh

@@ -1,11 +1,11 @@
 /**
- * @file PyProxy.hh
- * @author Caleb Aikens ([email protected])
- * @brief Struct for creating JS proxy objects. Used by DictType for object coercion
+ * @file PyProxyHandler.hh
+ * @author Caleb Aikens ([email protected]) and Philippe Laporte ([email protected])
+ * @brief Structs for creating JS proxy objects. Used by DictType for object coercion and by ListType for List coercion
  * @version 0.1
  * @date 2023-04-20
  *
- * Copyright (c) 2023 Distributive Corp.
+ * Copyright (c) 2023-2024 Distributive Corp.
  *
  */
 
@@ -30,6 +30,14 @@ public:
   bool isExtensible(JSContext *cx, JS::HandleObject proxy, bool *extensible) const override final;
 };
 
+enum ProxySlots {PyObjectSlot};
+
+typedef struct {
+  const char *name;      /* The name of the method */
+  JSNative call;         /* The C function that implements it */
+  uint16_t nargs;        /* The argument count for the method */
+} JSMethodDef;
+
 /**
  * @brief This struct is the ProxyHandler for JS Proxy Objects pythonmonkey creates to handle coercion from python dicts to JS Objects
  *
@@ -157,17 +165,27 @@ public:
     JS::HandleId id,
     JS::Handle<JS::PropertyDescriptor> desc,
     JS::ObjectOpResult &result) const override;
+
+  bool getBuiltinClass(JSContext *cx, JS::HandleObject proxy, js::ESClass *cls) const override;
 };
 
 /**
  * @brief This struct is the ProxyHandler for JS Proxy Objects pythonmonkey creates
- *    to handle coercion from python lists to JS Array-like objects
+ *    to handle coercion from python lists to JS Array objects
  */
 struct PyListProxyHandler : public PyBaseProxyHandler {
 public:
   PyListProxyHandler(PyObject *pyObj) : PyBaseProxyHandler(pyObj, &family) {};
   static const char family;
 
+  /**
+   * @brief Handles python object reference count when JS Proxy object is finalized
+   *
+   * @param gcx pointer to JS::GCContext
+   * @param proxy the proxy object being finalized
+   */
+  void finalize(JS::GCContext *gcx, JSObject *proxy) const override;
+
   bool getOwnPropertyDescriptor(
     JSContext *cx, JS::HandleObject proxy, JS::HandleId id,
     JS::MutableHandle<mozilla::Maybe<JS::PropertyDescriptor>> desc
@@ -180,6 +198,8 @@ public:
 
   bool ownPropertyKeys(JSContext *cx, JS::HandleObject proxy, JS::MutableHandleIdVector props) const override;
   bool delete_(JSContext *cx, JS::HandleObject proxy, JS::HandleId id, JS::ObjectOpResult &result) const override;
+  bool isArray(JSContext *cx, JS::HandleObject proxy, JS::IsArrayAnswer *answer) const override;
+  bool getBuiltinClass(JSContext *cx, JS::HandleObject proxy, js::ESClass *cls) const override;
 };
 
 /**