should have been part of previous commit

philippedistributive · philippedistributive · commit 72e5477db73f · 2024-01-29T18:28:08.000-05:00
diff --git a/src/JSArrayProxy.cc b/src/JSArrayProxy.cc
@@ -64,7 +64,7 @@ PyObject *JSArrayProxyMethodDefinitions::JSArrayProxy_get(JSArrayProxy *self, Py
       JS::RootedValue *value = new JS::RootedValue(GLOBAL_CX);
       JS_GetPropertyById(GLOBAL_CX, self->jsArray, id, value);
       JS::RootedObject *thisObj = new JS::RootedObject(GLOBAL_CX, self->jsArray);
-      return pyTypeFactory(GLOBAL_CX, global, value)->getPyObject();
+      return pyTypeFactory(GLOBAL_CX, thisObj, value)->getPyObject();
     }
     else if (PyUnicode_Check(key)) {
       if (strcmp(methodName, PyUnicode_AsUTF8(key)) == 0) {
@@ -75,7 +75,7 @@ PyObject *JSArrayProxyMethodDefinitions::JSArrayProxy_get(JSArrayProxy *self, Py
       JS::RootedValue *value = new JS::RootedValue(GLOBAL_CX);
       JS_GetPropertyById(GLOBAL_CX, self->jsArray, id, value);
       JS::RootedObject *thisObj = new JS::RootedObject(GLOBAL_CX, self->jsArray);
-      return pyTypeFactory(GLOBAL_CX, global, value)->getPyObject();
+      return pyTypeFactory(GLOBAL_CX, thisObj, value)->getPyObject();
     }
   }
 }
diff --git a/src/JSObjectProxy.cc b/src/JSObjectProxy.cc
@@ -104,7 +104,7 @@ PyObject *JSObjectProxyMethodDefinitions::JSObjectProxy_get(JSObjectProxy *self,
       JS::RootedValue *value = new JS::RootedValue(GLOBAL_CX);
       JS_GetPropertyById(GLOBAL_CX, self->jsObject, id, value);
       JS::RootedObject *thisObj = new JS::RootedObject(GLOBAL_CX, self->jsObject);
-      return pyTypeFactory(GLOBAL_CX, global, value)->getPyObject();
+      return pyTypeFactory(GLOBAL_CX, thisObj, value)->getPyObject();
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ PyObject JSArrayProxyMethodDefinitions::JSArrayProxy_get(JSArrayProxy self, Py`
`64`	`64`	`JS::RootedValue *value = new JS::RootedValue(GLOBAL_CX);`
`65`	`65`	`JS_GetPropertyById(GLOBAL_CX, self->jsArray, id, value);`
`66`	`66`	`JS::RootedObject *thisObj = new JS::RootedObject(GLOBAL_CX, self->jsArray);`
`67`		`- return pyTypeFactory(GLOBAL_CX, global, value)->getPyObject();`
	`67`	`+ return pyTypeFactory(GLOBAL_CX, thisObj, value)->getPyObject();`
`68`	`68`	`}`
`69`	`69`	`else if (PyUnicode_Check(key)) {`
`70`	`70`	`if (strcmp(methodName, PyUnicode_AsUTF8(key)) == 0) {`
`@@ -75,7 +75,7 @@ PyObject JSArrayProxyMethodDefinitions::JSArrayProxy_get(JSArrayProxy self, Py`
`75`	`75`	`JS::RootedValue *value = new JS::RootedValue(GLOBAL_CX);`
`76`	`76`	`JS_GetPropertyById(GLOBAL_CX, self->jsArray, id, value);`
`77`	`77`	`JS::RootedObject *thisObj = new JS::RootedObject(GLOBAL_CX, self->jsArray);`
`78`		`- return pyTypeFactory(GLOBAL_CX, global, value)->getPyObject();`
	`78`	`+ return pyTypeFactory(GLOBAL_CX, thisObj, value)->getPyObject();`
`79`	`79`	`}`
`80`	`80`	`}`
`81`	`81`	`}`
Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ PyObject JSObjectProxyMethodDefinitions::JSObjectProxy_get(JSObjectProxy self,`
`104`	`104`	`JS::RootedValue *value = new JS::RootedValue(GLOBAL_CX);`
`105`	`105`	`JS_GetPropertyById(GLOBAL_CX, self->jsObject, id, value);`
`106`	`106`	`JS::RootedObject *thisObj = new JS::RootedObject(GLOBAL_CX, self->jsObject);`
`107`		`- return pyTypeFactory(GLOBAL_CX, global, value)->getPyObject();`
	`107`	`+ return pyTypeFactory(GLOBAL_CX, thisObj, value)->getPyObject();`
`108`	`108`	`}`
`109`	`109`	`}`
`110`	`110`	`}`