refactor(jsTypeFactory): evaluate function object flags once

zollqir · zollqir · commit 7b6e71f3f519 · 2024-06-14T11:31:36.000-04:00
diff --git a/src/jsTypeFactory.cc b/src/jsTypeFactory.cc
@@ -331,10 +331,11 @@ bool callPyFunc(JSContext *cx, unsigned int argc, JS::Value *vp) {
   bool unknownNargs = false;
 
   if (PyCFunction_Check(pyFunc)) {
-    if (((PyCFunctionObject *)pyFunc)->m_ml->ml_flags & METH_NOARGS) { // 0 arguments
+    const int funcFlags = ((PyCFunctionObject *)pyFunc)->m_ml->ml_flags;
+    if (funcFlags & METH_NOARGS) { // 0 arguments
       nNormalArgs = 0;
     }
-    else if (((PyCFunctionObject *)pyFunc)->m_ml->ml_flags & METH_O) { // 1 argument
+    else if (funcFlags & METH_O) { // 1 argument
       nNormalArgs = 1;
     }
     else { // unknown number of arguments

Original file line number	Diff line number	Diff line change
`@@ -331,10 +331,11 @@ bool callPyFunc(JSContext cx, unsigned int argc, JS::Value vp) {`
`331`	`331`	`bool unknownNargs = false;`
`332`	`332`
`333`	`333`	`if (PyCFunction_Check(pyFunc)) {`
`334`		`- if (((PyCFunctionObject *)pyFunc)->m_ml->ml_flags & METH_NOARGS) { // 0 arguments`
	`334`	`+ const int funcFlags = ((PyCFunctionObject *)pyFunc)->m_ml->ml_flags;`
	`335`	`+ if (funcFlags & METH_NOARGS) { // 0 arguments`
`335`	`336`	`nNormalArgs = 0;`
`336`	`337`	`}`
`337`		`- else if (((PyCFunctionObject *)pyFunc)->m_ml->ml_flags & METH_O) { // 1 argument`
	`338`	`+ else if (funcFlags & METH_O) { // 1 argument`
`338`	`339`	`nNormalArgs = 1;`
`339`	`340`	`}`
`340`	`341`	`else { // unknown number of arguments`