fix(PythonExternalString): sizeOfBuffer now correctly returns the length of the python string

zollqir · zollqir · commit 84f00c40d003 · 2024-06-05T11:21:46.000-04:00
diff --git a/src/jsTypeFactory.cc b/src/jsTypeFactory.cc
@@ -69,7 +69,7 @@ void PythonExternalString::finalize(char16_t *chars) const
 
 size_t PythonExternalString::sizeOfBuffer(const char16_t *chars, mozilla::MallocSizeOf mallocSizeOf) const
 {
-  return 0;
+  return PyUnicode_GetLength(charToPyObjectMap[chars]);
 }
 
 PythonExternalString PythonExternalStringCallbacks = {};

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ void PythonExternalString::finalize(char16_t *chars) const`
`69`	`69`
`70`	`70`	`size_t PythonExternalString::sizeOfBuffer(const char16_t *chars, mozilla::MallocSizeOf mallocSizeOf) const`
`71`	`71`	`{`
`72`		`- return 0;`
	`72`	`+ return PyUnicode_GetLength(charToPyObjectMap[chars]);`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`PythonExternalString PythonExternalStringCallbacks = {};`