comment cleanup

philippedistributive · philippedistributive · commit a9e3cc9477db · 2024-01-26T18:50:34.000-05:00
diff --git a/src/jsTypeFactory.cc b/src/jsTypeFactory.cc
@@ -180,7 +180,7 @@ JS::Value jsTypeFactory(JSContext *cx, PyObject *object) {
       JS_GetClassPrototype(cx, JSProto_Object, &objectPrototype); // so that instanceof will work, not that prototype methods will
       proxy = js::NewProxyObject(cx, new PyDictProxyHandler(object), v, objectPrototype.get());
     }
-    Py_INCREF(object); // TODO leak! clean up in finalize
+    Py_INCREF(object);
     JS::SetReservedSlot(proxy, PyObjectSlot, JS::PrivateValue(object));
     returnType.setObject(*proxy);
   }

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ JS::Value jsTypeFactory(JSContext cx, PyObject object) {`
`180`	`180`	`JS_GetClassPrototype(cx, JSProto_Object, &objectPrototype); // so that instanceof will work, not that prototype methods will`
`181`	`181`	`proxy = js::NewProxyObject(cx, new PyDictProxyHandler(object), v, objectPrototype.get());`
`182`	`182`	`}`
`183`		`- Py_INCREF(object); // TODO leak! clean up in finalize`
	`183`	`+ Py_INCREF(object);`
`184`	`184`	`JS::SetReservedSlot(proxy, PyObjectSlot, JS::PrivateValue(object));`
`185`	`185`	`returnType.setObject(*proxy);`
`186`	`186`	`}`