Skip to content

Commit afdced2

Browse files
committed
feat(CI): remove core dumps as CI artifacts
1 parent e773351 commit afdced2

File tree

1 file changed

+0
-19
lines changed

1 file changed

+0
-19
lines changed

.github/workflows/test-and-publish.yaml

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -247,18 +247,6 @@ jobs:
247247
with:
248248
name: wheel-${{ github.run_id }}-${{ github.sha }}-${{ runner.os }}_${{ runner.arch }}_Python${{ matrix.python_version }}
249249
path: ./dist/
250-
- name: Set cores to get stored in /cores
251-
if: ${{ matrix.os != 'windows-2022' }}
252-
# TODO (Caleb Aikens) figure out how to get Windows core dumps
253-
run: |
254-
sudo mkdir -p /cores
255-
sudo chmod 777 /cores
256-
# Core filenames will be of the form osname.pythonversion.executable.pid.timestamp:
257-
if [[ "$OSTYPE" == "linux-gnu"* ]]; then
258-
sudo bash -c 'echo "/cores/${OSTYPE}.$(poetry run python --version).%e.%p.%t" > /proc/sys/kernel/core_pattern'
259-
else
260-
sudo sysctl kern.corefile="/cores/${OSTYPE}.$(poetry run python --version).%e.%p.%y"
261-
fi
262250
- name: Run Python tests (pytest)
263251
run: |
264252
if [[ "$OSTYPE" == "linux-gnu"* || "$OSTYPE" == "darwin"* ]]; then
@@ -281,13 +269,6 @@ jobs:
281269
uses: fawazahmed0/action-debug@main
282270
with:
283271
credentials: "admin:admin"
284-
- name: Upload core dumps as CI artifacts
285-
uses: actions/upload-artifact@v4
286-
if: ${{ matrix.os != 'windows-2022' && failure() }}
287-
# TODO (Caleb Aikens) figure out how to get Windows core dumps
288-
with:
289-
name: cores-${{ matrix.os }}-${{ matrix.python_version }}
290-
path: /cores
291272
sdist:
292273
runs-on: ubuntu-22.04
293274
steps:

0 commit comments

Comments
 (0)