refactor: return timeoutID using .setNumber()

Xmader · Xmader · commit b1c3b6b4daeb · 2024-02-16T14:22:04.000Z
diff --git a/src/internalBinding/timers.cc b/src/internalBinding/timers.cc
@@ -32,7 +32,7 @@ static bool enqueueWithDelay(JSContext *cx, unsigned argc, JS::Value *vp) {
   PyEventLoop::AsyncHandle handle = loop.enqueueWithDelay(job, delaySeconds);
 
   // Return the `timeoutID` to use in `clearTimeout`
-  args.rval().setDouble((double)PyEventLoop::AsyncHandle::getUniqueId(std::move(handle)));
+  args.rval().setNumber(PyEventLoop::AsyncHandle::getUniqueId(std::move(handle)));
   return true;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ static bool enqueueWithDelay(JSContext cx, unsigned argc, JS::Value vp) {`
`32`	`32`	`PyEventLoop::AsyncHandle handle = loop.enqueueWithDelay(job, delaySeconds);`
`33`	`33`
`34`	`34`	// Return the `timeoutID` to use in `clearTimeout`
`35`		`- args.rval().setDouble((double)PyEventLoop::AsyncHandle::getUniqueId(std::move(handle)));`
	`35`	`+ args.rval().setNumber(PyEventLoop::AsyncHandle::getUniqueId(std::move(handle)));`
`36`	`36`	`return true;`
`37`	`37`	`}`
`38`	`38`