Update src/PyDictProxyHandler.cc

philippedistributive · zollqir · web-flow · commit ba453172a793 · 2024-04-22T12:25:36.000-04:00
Co-authored-by: Caleb Aikens &lt;caleb@distributive.network&gt;
diff --git a/src/PyDictProxyHandler.cc b/src/PyDictProxyHandler.cc
@@ -68,9 +68,12 @@ bool PyDictProxyHandler::set(JSContext *cx, JS::HandleObject proxy, JS::HandleId
   PyObject *attrName = idToKey(cx, id);
 
   PyObject *self = JS::GetMaybePtrFromReservedSlot<PyObject>(proxy, PyObjectSlot);
-  if (PyDict_SetItem(self, attrName, pyTypeFactory(cx, rootedV))) {
+  PyObject *value = pyTypeFactory(cx, rootedV);
+  if (PyDict_SetItem(self, attrName, value)) {
+    Py_DECREF(value);
     return result.failCantSetInterposed(); // raises JS exception
   }
+  Py_DECREF(value);
   return result.succeed();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -68,9 +68,12 @@ bool PyDictProxyHandler::set(JSContext *cx, JS::HandleObject proxy, JS::HandleId`
`68`	`68`	`PyObject *attrName = idToKey(cx, id);`
`69`	`69`
`70`	`70`	`PyObject *self = JS::GetMaybePtrFromReservedSlot<PyObject>(proxy, PyObjectSlot);`
`71`		`- if (PyDict_SetItem(self, attrName, pyTypeFactory(cx, rootedV))) {`
	`71`	`+ PyObject *value = pyTypeFactory(cx, rootedV);`
	`72`	`+ if (PyDict_SetItem(self, attrName, value)) {`
	`73`	`+ Py_DECREF(value);`
`72`	`74`	`return result.failCantSetInterposed(); // raises JS exception`
`73`	`75`	`}`
	`76`	`+ Py_DECREF(value);`
`74`	`77`	`return result.succeed();`
`75`	`78`	`}`
`76`	`79`