Skip to content

Commit bbcadf9

Browse files
Xmaderzollqir
andauthored
refactor(JSObjectProxy): remove commented code
Co-authored-by: Caleb Aikens <[email protected]>
1 parent b1bcc4a commit bbcadf9

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

src/JSObjectProxy.cc

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -73,13 +73,6 @@ Py_ssize_t JSObjectProxyMethodDefinitions::JSObjectProxy_length(JSObjectProxy *s
7373

7474
PyObject *JSObjectProxyMethodDefinitions::JSObjectProxy_get(JSObjectProxy *self, PyObject *key)
7575
{
76-
// // XXX: If we ban access of the `.keys()` method from Python internals, we can force to-dict conversion by iterating over the sequence of key-value pairs
77-
// // see also: https://docs.python.org/3/c-api/dict.html#c.PyDict_Update
78-
// if (PyUnicode_CompareWithASCIIString(key, "keys") == 0) {
79-
// PyErr_SetString(PyExc_AttributeError, "Use for-in iterator instead.");
80-
// return NULL;
81-
// }
82-
8376
JS::RootedId id(GLOBAL_CX);
8477
if (!keyToId(key, &id)) {
8578
// TODO (Caleb Aikens): raise exception here

0 commit comments

Comments
 (0)