Skip to content

Commit c6efa76

Browse files
committed
build(setup.sh): add missing pkgs on fresh ubuntu systems
In a fresh docker container in `ubuntu:20.04`, `curl` isn't installed by default. After installing `git` and `sudo`, I ran `setup.sh` and ran into "curl: command not found". Given that `setup.sh` uses `curl` right after installing it on Ubuntu machines, we may as well make sure it's available before using it. After resolving that, Poetry failed to install due to the python module `distutils` being missing [^1]. Fixing it through installing `python3-distutils` seems to work [^2]! After troubleshooting OS/machine specific dependency setup issues (e.g., `npm`, latest `cmake`), I had to add `python3-dev` to make `setup.sh` match what the README file mentions in the "Build Instructions" section. [^1]: pypa/get-pip#124 [^2]: pypa/get-pip#124 (comment)
1 parent 59642c3 commit c6efa76

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

setup.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ CPUS=$(getconf _NPROCESSORS_ONLN 2>/dev/null || getconf NPROCESSORS_ONLN 2>/dev/
99
echo "Installing dependencies"
1010
if [[ "$OSTYPE" == "linux-gnu"* ]]; then # Linux
1111
sudo apt-get update --yes
12-
sudo apt-get install cmake doxygen graphviz llvm g++ pkg-config m4 wget --yes
12+
sudo apt-get install --yes cmake doxygen graphviz llvm g++ pkg-config m4 \
13+
wget curl python3-distutils python3-dev
1314
elif [[ "$OSTYPE" == "darwin"* ]]; then # macOS
1415
brew update || true # allow failure
1516
brew install cmake doxygen graphviz pkg-config wget coreutils # `coreutils` installs the `realpath` command

0 commit comments

Comments
 (0)