Skip to content

Commit c9e48bd

Browse files
committed
add detailed TODO comments
1 parent eb0ca8a commit c9e48bd

File tree

1 file changed

+16
-12
lines changed

1 file changed

+16
-12
lines changed

python/pythonmonkey/builtin_modules/event-target.js

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -26,53 +26,53 @@ class Event
2626
* Indicates whether the event is cancelable.
2727
* @type {Boolean}
2828
*/
29-
cancelable = true;
29+
cancelable = true;
3030

3131
/**
3232
* Indicates whether the event can bubble across the boundary between the shadow DOM and the regular DOM.
3333
* @type {Boolean}
3434
*/
35-
composed = false;
35+
composed = false;
3636

3737
/**
3838
* The element to which the event handler has been attached.
3939
* @type {EventTarget}
4040
*/
41-
currentTarget = null;
41+
currentTarget = null;
4242

4343
/**
4444
* Indicates whether the call to event.preventDefault() canceled the event.
4545
* @type {Boolean}
4646
*/
47-
devaultPrevented = false;
47+
devaultPrevented = false;
4848

4949
/**
5050
* Indicates which phase of the event flow is currently being evaluated.
5151
* @type {Number}
5252
*/
53-
eventPhase = Event.NONE;
54-
static NONE = 0; // The event is not being processed
55-
static CAPTURING_PHASE = 1; // The event is being propagated through the target's ancestor objects
56-
static AT_TARGET = 2; // The event has arrived at the event's target
57-
static BUBBLING_PHASE = 3; // The event is propagating back up through the target's ancestors in reverse order, starting with the parent
53+
eventPhase = Event.NONE;
54+
static NONE = 0; // The event is not being processed
55+
static CAPTURING_PHASE = 1; // The event is being propagated through the target's ancestor objects
56+
static AT_TARGET = 2; // The event has arrived at the event's target
57+
static BUBBLING_PHASE = 3; // The event is propagating back up through the target's ancestors in reverse order, starting with the parent
5858

5959
/**
6060
* Indicates whether the event was initiated by the browser or by a script.
6161
* @type {Boolean}
6262
*/
63-
isTrusted = false;
63+
isTrusted = false;
6464

6565
/**
6666
* A reference to the object to which the event was originally dispatched.
6767
* @type {EventTarget}
6868
*/
69-
target = null;
69+
target = null;
7070

7171
/**
7272
* The time at which the event was created (in milliseconds). By specification, this value is time since epoch.
7373
* @type {Number}
7474
*/
75-
timeStamp = null;
75+
timeStamp = null;
7676

7777
/**
7878
* The name identifying the type of the event.
@@ -87,6 +87,10 @@ class Event
8787
{
8888
this.type = type;
8989
}
90+
91+
// TODO: missing instance methods: Event.preventDefault(), Event.composedPath(), Event.stopImmediatePropagation(), Event.stopPropagation()
92+
// See https://developer.mozilla.org/en-US/docs/Web/API/Event#instance_methods
93+
// Also we need to figure out how we could handle event bubbling and capture in the PythonMonkey environment.
9094
}
9195

9296
/**

0 commit comments

Comments
 (0)