The JS_Utf8BufferIsCompilableUnit issue got fixed within 24 hours after reporting it in the firefox Matrix chat, updating SpiderMonkey to mozilla-central tip

Xmader · Xmader · commit da4f0da5b999 · 2024-07-02T21:53:49.000Z
See https://bugzilla.mozilla.org/show_bug.cgi?id=1904747
diff --git a/mozcentral.version b/mozcentral.version
@@ -1 +1 @@
-74b39df74a4a38e44f4b3783a5c4e4e8980ccf6f
+d25c9bdacb64ae50779dc91f5919ca0189ad6c36
diff --git a/src/modules/pythonmonkey/pythonmonkey.cc b/src/modules/pythonmonkey/pythonmonkey.cc
@@ -488,7 +488,6 @@ static PyObject *isCompilableUnit(PyObject *self, PyObject *args) {
   if (JS_Utf8BufferIsCompilableUnit(GLOBAL_CX, *global, bufferUtf8, strlen(bufferUtf8))) {
     Py_RETURN_TRUE;
   } else {
-    JS_ClearPendingException(GLOBAL_CX); // JS_Utf8BufferIsCompilableUnit would still generate exception for invalid inputs
     Py_RETURN_FALSE;
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -488,7 +488,6 @@ static PyObject isCompilableUnit(PyObject self, PyObject *args) {`
`488`	`488`	`if (JS_Utf8BufferIsCompilableUnit(GLOBAL_CX, *global, bufferUtf8, strlen(bufferUtf8))) {`
`489`	`489`	`Py_RETURN_TRUE;`
`490`	`490`	`} else {`
`491`		`- JS_ClearPendingException(GLOBAL_CX); // JS_Utf8BufferIsCompilableUnit would still generate exception for invalid inputs`
`492`	`491`	`Py_RETURN_FALSE;`
`493`	`492`	`}`
`494`	`493`	`}`