Skip to content

Commit dc4442d

Browse files
committed
WIP: remove the use of the _PyArg_CheckPositional private API
1 parent fc734e2 commit dc4442d

File tree

2 files changed

+0
-20
lines changed

2 files changed

+0
-20
lines changed

src/JSArrayProxy.cc

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -789,10 +789,6 @@ PyObject *JSArrayProxyMethodDefinitions::JSArrayProxy_insert(JSArrayProxy *self,
789789
Py_ssize_t index;
790790
PyObject *value;
791791

792-
if (!_PyArg_CheckPositional("insert", nargs, 2, 2)) {
793-
return NULL;
794-
}
795-
796792
{
797793
Py_ssize_t ival = -1;
798794
PyObject *iobj = PyNumber_Index(args[0]);
@@ -899,10 +895,6 @@ PyObject *JSArrayProxyMethodDefinitions::JSArrayProxy_extend(JSArrayProxy *self,
899895
PyObject *JSArrayProxyMethodDefinitions::JSArrayProxy_pop(JSArrayProxy *self, PyObject *const *args, Py_ssize_t nargs) {
900896
Py_ssize_t index = -1;
901897

902-
if (!_PyArg_CheckPositional("pop", nargs, 0, 1)) {
903-
return NULL;
904-
}
905-
906898
if (nargs >= 1) {
907899
Py_ssize_t ival = -1;
908900
PyObject *iobj = PyNumber_Index(args[0]);
@@ -987,9 +979,6 @@ PyObject *JSArrayProxyMethodDefinitions::JSArrayProxy_index(JSArrayProxy *self,
987979
Py_ssize_t start = 0;
988980
Py_ssize_t stop = PY_SSIZE_T_MAX;
989981

990-
if (!_PyArg_CheckPositional("index", nargs, 1, 3)) {
991-
return NULL;
992-
}
993982
value = args[0];
994983
if (nargs < 2) {
995984
goto skip_optional;

src/JSObjectProxy.cc

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -620,9 +620,6 @@ PyObject *JSObjectProxyMethodDefinitions::JSObjectProxy_get_method(JSObjectProxy
620620
PyObject *key;
621621
PyObject *default_value = Py_None;
622622

623-
if (!_PyArg_CheckPositional("get", nargs, 1, 2)) {
624-
return NULL;
625-
}
626623
key = args[0];
627624
if (nargs < 2) {
628625
goto skip_optional;
@@ -644,9 +641,6 @@ PyObject *JSObjectProxyMethodDefinitions::JSObjectProxy_setdefault_method(JSObje
644641
PyObject *key;
645642
PyObject *default_value = Py_None;
646643

647-
if (!_PyArg_CheckPositional("setdefault", nargs, 1, 2)) {
648-
return NULL;
649-
}
650644
key = args[0];
651645
if (nargs < 2) {
652646
goto skip_optional;
@@ -676,9 +670,6 @@ PyObject *JSObjectProxyMethodDefinitions::JSObjectProxy_pop_method(JSObjectProxy
676670
PyObject *key;
677671
PyObject *default_value = NULL;
678672

679-
if (!_PyArg_CheckPositional("pop", nargs, 1, 2)) {
680-
return NULL;
681-
}
682673
key = args[0];
683674
if (nargs < 2) {
684675
goto skip_optional;

0 commit comments

Comments
 (0)