Skip to content

Commit dcfbb34

Browse files
committed
fix(JobQueue): the JobQueue::getIncumbentGlobal method has been removed from the definition in new SpiderMonkey version
1 parent 7f8cdd6 commit dcfbb34

File tree

2 files changed

+0
-13
lines changed

2 files changed

+0
-13
lines changed

include/JobQueue.hh

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,6 @@ explicit JobQueue(JSContext *cx);
3434
*/
3535
bool init(JSContext *cx);
3636

37-
/**
38-
* @brief Ask the embedding for the incumbent global.
39-
*
40-
* SpiderMonkey doesn't itself have a notion of incumbent globals as defined
41-
* by the HTML spec, so we need the embedding to provide this. See
42-
* dom/script/ScriptSettings.h for details.
43-
*/
44-
JSObject *getIncumbentGlobal(JSContext *cx) override;
45-
4637
/**
4738
* @brief Enqueue a reaction job `job` for `promise`, which was allocated at
4839
* `allocationSite`. Provide `incumbentGlobal` as the incumbent global for

src/JobQueue.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,6 @@ JobQueue::JobQueue(JSContext *cx) {
2626
finalizationRegistryCallbacks = new JS::PersistentRooted<FunctionVector>(cx); // Leaks but it's OK since freed at process exit
2727
}
2828

29-
JSObject *JobQueue::getIncumbentGlobal(JSContext *cx) {
30-
return JS::CurrentGlobalOrNull(cx);
31-
}
32-
3329
bool JobQueue::enqueuePromiseJob(JSContext *cx,
3430
[[maybe_unused]] JS::HandleObject promise,
3531
JS::HandleObject job,

0 commit comments

Comments
 (0)