Skip to content

Commit ff4c7d1

Browse files
committed
fix(build.py): move submodule checkout to the commonjs testing script
1 parent 5b98812 commit ff4c7d1

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

build.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ def copy_artifacts():
5252
execute("cp ./_spidermonkey_install/lib/libmozjs* ./python/pythonmonkey/", cwd=TOP_DIR)
5353

5454
def build():
55-
execute("git submodule update --init --recursive || echo 'Skipping. We are installing from an sdist tarball.'", cwd=TOP_DIR)
5655
ensure_spidermonkey()
5756
run_cmake_build()
5857
copy_artifacts()

tests/js/commonjs-modules.bash

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,11 @@ panic()
1111
echo "$*" >&2
1212
exit 2
1313
}
14-
cd `dirname "$0"`/../commonjs-official/tests/modules/1.0 || panic "could not change to test directory"
14+
15+
cd `dirname "$0"`
16+
git submodule update --init --recursive || panic "could not checkout the required git submodule"
17+
18+
cd ../commonjs-official/tests/modules/1.0 || panic "could not change to test directory"
1519

1620
runTest()
1721
{

0 commit comments

Comments
 (0)