From a1f75bbc574f26f914b03e4f8adf017cce8386b3 Mon Sep 17 00:00:00 2001 From: Tom Tang Date: Mon, 19 Aug 2024 20:04:08 +0000 Subject: [PATCH] chore: remove the installation of doxygen + graphviz from `setup.sh` `doxygen` and `graphviz` are only required to generate the docs. Compiling PythonMonkey doesn't actually need them. The CI job to generate the docs (for https://docs.pythonmonkey.io/) will install doxygen on its own in https://github.com/Distributive-Network/PythonMonkey/blob/2633b5a/.github/workflows/test-and-publish.yaml#L168-L177. There's no point to install them automatically in `setup.sh`, if the user doesn't care about the docs. --- setup.sh | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/setup.sh b/setup.sh index 34ba0880..bbe1b272 100755 --- a/setup.sh +++ b/setup.sh @@ -13,18 +13,11 @@ if [[ "$OSTYPE" == "linux-gnu"* ]]; then # Linux SUDO='sudo' fi echo "Installing apt packages" - $SUDO apt-get install --yes cmake graphviz llvm clang pkg-config m4 unzip \ + $SUDO apt-get install --yes cmake llvm clang pkg-config m4 unzip \ wget curl python3-dev - # Install Doxygen - # the newest version in Ubuntu 20.04 repository is 1.8.17, but we need Doxygen 1.9 series - echo "Installing doxygen" - wget -c -q https://www.doxygen.nl/files/doxygen-1.9.7.linux.bin.tar.gz - tar xf doxygen-1.9.7.linux.bin.tar.gz - cd doxygen-1.9.7 && $SUDO make install && cd - - rm -rf doxygen-1.9.7 doxygen-1.9.7.linux.bin.tar.gz elif [[ "$OSTYPE" == "darwin"* ]]; then # macOS brew update || true # allow failure - brew install cmake doxygen pkg-config wget unzip coreutils # `coreutils` installs the `realpath` command + brew install cmake pkg-config wget unzip coreutils # `coreutils` installs the `realpath` command elif [[ "$OSTYPE" == "msys"* ]]; then # Windows echo "Dependencies are not going to be installed automatically on Windows." else